Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent popup content from being selected on double click on the container #2722

Merged

Conversation

limonte
Copy link
Member

@limonte limonte commented Apr 17, 2024

fixing this:

CleanShot 2024-04-17 at 17 31 27

Summary by CodeRabbit

  • Bug Fixes
    • Improved user interaction by preventing text selection on double-click within modal containers.

Copy link
Contributor

coderabbitai bot commented Apr 17, 2024

Walkthrough

The update introduces a modification to the handleContainerMousedown function, enhancing the user interface by preventing text selection within the modal when the container is double-clicked. This change ensures a smoother and more user-friendly interaction with the modal components.

Changes

File Change Summary
src/.../popup-click-handler.js Added a check to prevent text selection on double-click in the modal container.

🐇✨
In the land of code, where clicks are king,
A rabbit hopped and made a fix:
No more text dance on double ping,
Smooth and steady, no more tricks!
Celebrate, for ease does spring! 🎉
🐇✨


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 459b30c and ba0362c.
Files selected for processing (1)
  • src/popup-click-handler.js (1 hunks)
Additional comments not posted (1)
src/popup-click-handler.js (1)

74-78: Prevent text selection on double-click by preventing default behavior when the container itself is the target.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@limonte limonte merged commit 7910325 into main Apr 17, 2024
1 of 2 checks passed
@limonte limonte deleted the fix/prevent-modal-content-selection-when-double-clicking-outside branch April 17, 2024 14:35
github-actions bot pushed a commit that referenced this pull request Apr 17, 2024
## [11.10.8](v11.10.7...v11.10.8) (2024-04-17)

### Bug Fixes

* prevent popup content from being selected on double click on the container ([#2722](#2722)) ([7910325](7910325))
@limonte
Copy link
Member Author

limonte commented Apr 17, 2024

🎉 This PR is included in version 11.10.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant