Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/extract withGlobalDefaults #1045

Merged
merged 3 commits into from Mar 27, 2018

Conversation

zenflow
Copy link
Member

@zenflow zenflow commented Mar 27, 2018

Towards #1044

@zenflow zenflow requested a review from limonte March 27, 2018 12:38
@zenflow
Copy link
Member Author

zenflow commented Mar 27, 2018

With the deprecation warning I added last commit, the documentation site should be updated before publishing this (edit) updated in regards to Swal.mixin()

Copy link
Member

@limonte limonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zenflow you are building a strong foundation for the bright future of SweetAlert2 🌞

@limonte limonte merged commit 1033ff3 into master Mar 27, 2018
@zenflow
Copy link
Member Author

zenflow commented Mar 27, 2018

@limonte 👍 Be sure not to publish before sweetalert2.github.io is updated in regards to Swal.mixin

@zenflow
Copy link
Member Author

zenflow commented Mar 27, 2018

@limonte or users will get a deprecation notice saying to switch to using a method that's not documented yet

@limonte
Copy link
Member

limonte commented Mar 27, 2018

@zenflow roger!

@zenflow
Copy link
Member Author

zenflow commented Mar 27, 2018

@limonte How are you liking Swal.mixin in practice?

@limonte
Copy link
Member

limonte commented Mar 27, 2018

How are you liking Swal.mixin in practice?

Can't live without it! :) Swal.mixin helped to eliminate tens of copy-pasted LoC with repetitive parameters.

@zenflow
Copy link
Member Author

zenflow commented Apr 19, 2018

@limonte 👍 Be sure not to publish before sweetalert2.github.io is updated in regards to Swal.mixin
@limonte or users will get a deprecation notice saying to switch to using a method that's not documented yet

Eh, I guess we should get that documentation updated quickly since this is released in 7.19.0. I'll make a PR to the documentation site just adding the Swal.mixin method, and I think the rest of the edits (e.g. swal -> Swal can come in the new site.

@limonte
Copy link
Member

limonte commented Apr 20, 2018

@limonte +1 Be sure not to publish before sweetalert2.github.io is updated in regards to Swal.mixin
@limonte or users will get a deprecation notice saying to switch to using a method that's not documented yet

Oops. I forgot about this, apologies.

I'll make a PR to the documentation site just adding the Swal.mixin method, and I think the rest of the edits (e.g. swal -> Swal can come in the new site.

👍

@limonte limonte deleted the refactor/extract-withGlobalDefaults branch April 21, 2018 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants