Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor/extract features #1044

Open
zenflow opened this issue Mar 27, 2018 · 1 comment
Open

refactor/extract features #1044

zenflow opened this issue Mar 27, 2018 · 1 comment
Assignees
@zenflow
Labels
type: refactor

Comments

@zenflow
Copy link
Member

zenflow commented Mar 27, 2018

So having things split into modules now after #970 is awesome, but I want to go a step further in organizing the code base and start separating concerns by extracting distinct features into separate layers, as "core" Swal extensions in modules in the src/extensions dir. I commented about this here #1036 (comment) and here #1043 (comment)
@zenflow zenflow self-assigned this Mar 27, 2018
@zenflow zenflow mentioned this issue Mar 27, 2018
Merged
@zenflow
Copy link
Member Author

zenflow commented Mar 27, 2018

Some of these we can move outside this repository, like I'm proposing we do with the "global defaults" feature here 2fc3d01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenflow zenflow

Labels
type: refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zenflow