fix(minifier): preserve unsafe object spreads#11820
Draft
kdy1 wants to merge 1 commit intoswc-project:mainfrom
Draft
fix(minifier): preserve unsafe object spreads#11820kdy1 wants to merge 1 commit intoswc-project:mainfrom
kdy1 wants to merge 1 commit intoswc-project:mainfrom
Conversation
|
Contributor
Binary Sizes
Commit: 97452c7 |
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__proto__, computed keys, accessors, impure values, and methods containingsuperas unsafe spread barriers."focal_tweet"source literal while preserving computed-property registration behavior.Test Plan
git submodule update --init --recursiveUPDATE=1 cargo test -p swc_ecma_minifier --test compress custom_fixture_tests__fixture__issues__object_spread_frozen_key__input_js -- --ignoredcargo test -p swc_ecma_minifier --test compress custom_fixture_tests__fixture__issues__object_spread_frozen_key__input_js -- --ignored(cd crates/swc_ecma_minifier && ./scripts/exec.sh)cargo fmt --allcargo clippy --all --all-targets -- -D warningscargo test -p swc_ecma_minifiernode crates/swc_ecma_minifier/tests/fixture/issues/object-spread-frozen-key/output.js