Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Quickswap #5237

Merged
merged 8 commits into from
Jun 8, 2024
Merged

Fix: Quickswap #5237

merged 8 commits into from
Jun 8, 2024

Conversation

J94k
Copy link
Collaborator

@J94k J94k commented Feb 26, 2024

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the work on the Testnet
  • I checked the work on the Mainnet
  • I checked the work in the plugin
  • I checked the PR once again

Tests

Please start auto tests as follows:

  • add a label swap test to start swap tests
  • add a label withdraw test to start withdraw tests

You can skip these tests if you completely sure that your changes aren't related to this functional

Original issue

Video / screenshot proof

@J94k J94k mentioned this pull request Feb 26, 2024
Closed
11 tasks
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Feb 26, 2024 •
edited

Deploying multicurrencywallet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0b7fa95
Status: ✅  Deploy successful!
Preview URL: https://bd06791c.multicurrencywallet-btg.pages.dev
Branch Preview URL: https://fix-quickswap-api.multicurrencywallet-btg.pages.dev

View logs

@J94k J94k marked this pull request as ready for review May 31, 2024 06:27
@J94k J94k merged commit d15939a into master Jun 8, 2024
2 checks passed
@J94k J94k deleted the fix-quickswap-api branch June 8, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noxonsu noxonsu noxonsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@J94k @noxonsu