feat: add sv #32
Open
feat: add sv #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If i undersand that correctly |
|
Running |
dominikg
reviewed
Jul 11, 2025
| branch: 'main', | ||
| build: 'pnpm build', | ||
| beforeTest: | ||
| 'pnpm playwright install chromium && pnpx storybook@latest --version', // prefetch the storybook cli to reduce fetching errors in tests |
There was a problem hiding this comment.
is the storybook cli used by the tests also always "latest"? what happens if they release a new major?
If possible make it a devDependency and call it via pnpm storybook just like playwright
|
main has been updated and should no longer have audit errors, changes to package.json & lockfile can be reverted here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
sv, Relates sveltejs/cli#622