Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export CookieSerializeOptions type #12171

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

phdoshi
Copy link

@phdoshi phdoshi commented Apr 29, 2024

Creates and exports a custom CustomCookieSerializeOptions type for issue #11799, edited in the following files:

  • types.d.ts
  • cookie.js
  • public.d.ts
  • index.d.ts

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Apr 29, 2024

⚠️ No Changeset found

Latest commit: 7b18516

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -236,7 +236,8 @@ export interface Cookies {
set(
name: string,
value: string,
opts: import('cookie').CookieSerializeOptions & { path: string }
opts: import('../runtime/server/page/types.d.ts').CustomCookieSerializeOptions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert at the types setup, but there's nothing else in this file importing from ../runtime which makes me think it's the wrong place to put it. everything else is being imported from private

Also, let's drop Custom from the name. All of the types we defined are specific to SvelteKit. No need to prefix all of them with Custom...

@eltigerchino eltigerchino changed the title Forced cookie path change breaks re-use of CookieSerializeOptions #11799 feat: export CookieSerializeOptions type May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants