Skip to content

feat(add): Add minimum Node.js version warning if below 16. #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jycouet
Copy link
Contributor

@jycouet jycouet commented Jun 29, 2025

Closes: #199

Copy link

changeset-bot bot commented Jun 29, 2025

🦋 Changeset detected

Latest commit: 072f20c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jun 29, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@625
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@625

commit: 072f20c

Copy link
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start!

@jycouet jycouet requested a review from manuel3108 July 5, 2025 08:11
@AdrianGonz97
Copy link
Member

im not seeing any discussions for it, but couldn't we just add an engines field to sv's package.json instead so node can do the version check for us? @manuel3108 @benmccann

@manuel3108
Copy link
Member

I think I did some research last week and I think I remembered that npx and similar are not checking the node version for whatever reason. I haven't tested it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add minimum Node.js version warning to sv
4 participants