Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve some typings #5422

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SamMousa
Copy link
Contributor

No description provided.

@SamMousa
Copy link
Contributor Author

Can this be reviewed? Tests fail because they are brittle not because there's anything wrong with the code.

@tsv2013
Copy link
Member

tsv2013 commented Apr 24, 2024

Please check error logs. Linter checks are not passed:

D:\a\1\s\survey-creator\packages\survey-creator-core\src\property-grid\index.ts
673:29 error Expected a comma @typescript-eslint/member-delimiter-style
674:24 error Expected a comma @typescript-eslint/member-delimiter-style

D:\a\1\s\survey-creator\packages\survey-creator-core\src\property-grid\values.ts
22:28 error Expected a comma @typescript-eslint/member-delimiter-style

✖ 3 problems (3 errors, 0 warnings)
3 errors and 0 warnings potentially fixable with the --fix option.

@SamMousa
Copy link
Contributor Author

Thanks for the feedback! I did actually (try to) interpret the logs, but honestly it's very unclear with the use of azure pipelines for anyone not familiar with them.

I've created #5434 to aid future contributors including myself.

@JaneSjs JaneSjs requested a review from tsv2013 November 18, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants