-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Admin API front-end #6
Open
mirhmousavi
wants to merge
3
commits into
master
Choose a base branch
from
mir-use-admin-api
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
May 3, 2024 13:57
4782ff0
to
66ad2d5
Compare
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
May 7, 2024 11:55
53b78e5
to
66ad2d5
Compare
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
May 13, 2024 12:23
66ad2d5
to
3e91b16
Compare
jsnjack
reviewed
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the pr from my review list. Please re-request a review when the pending changes are addressed and everything is ready. Thanks!
aogz
approved these changes
May 23, 2024
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
May 27, 2024 08:38
8e21241
to
aa311fc
Compare
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
June 11, 2024 11:07
dc04255
to
3f89e71
Compare
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
June 11, 2024 11:13
3f89e71
to
1c7e85b
Compare
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
June 11, 2024 11:17
1c7e85b
to
5665420
Compare
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
June 11, 2024 11:21
5665420
to
713bc20
Compare
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
June 11, 2024 11:22
713bc20
to
72162e4
Compare
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
June 11, 2024 11:29
72162e4
to
2f1e0f9
Compare
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
June 11, 2024 11:31
2f1e0f9
to
b86e565
Compare
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
June 11, 2024 11:34
b86e565
to
5f34c94
Compare
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
June 11, 2024 11:37
5f34c94
to
67207ac
Compare
mirhmousavi
force-pushed
the
mir-use-admin-api
branch
from
June 11, 2024 11:57
67207ac
to
881f72d
Compare
jsnjack
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the front-end part of Admin API integration changes.
To make it easy to review I kept changes as minimum as possible
The back-end changes PR can be found https://github.com/surfly/nic-surfly-integration/pull/68