Fix 'super' usage in arrow functions. #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimaIT
approved these changes
May 22, 2024
pmenichelli
approved these changes
May 27, 2024
| @@ -3916,7 +3916,9 @@ export function parseSuperExpression( | |||
| case Token.LeftParen: { | |||
| // The super property has to be within a class constructor | |||
| if ((context & Context.SuperCall) === 0) report(parser, Errors.SuperNoConstructor); | |||
| if (context & Context.InClass) report(parser, Errors.InvalidSuperProperty); | |||
| if (context & Context.InClass && !(context & Context.InMethod)) { | |||
There was a problem hiding this comment.
is there a reason why the optional chaining operator is not used here?
There was a problem hiding this comment.
It's because here the bitwise AND & is used or am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes all issues described in this ticket https://github.com/surfly/it/issues/4581