Handle correctly octal or hex values located in template strings #29
Conversation
ypapouski
changed the title
| "(function() { return () => {}; })()`'\\00a0'`", | ||
| "(function tag() {})`'\\00a0'`", | ||
| "(function() {})`'\\00a0'`", | ||
| 'String.raw`{\rtf1adeflang1025ansiansicpg1252\\uc1`;' |
There was a problem hiding this comment.
Looks like the case from the ticket is still not working.
Tested on https://meriyah.github.io/meriyah/
String.raw`{\rtf1\adeflang1025\ansi\ansicpg1252\uc1`;
// > [1:49]: Invalid hexadecimal escape sequence
There was a problem hiding this comment.
Actually none of my examples are working in this app and I believe it's because that my fix is available only in version v4.4.2. The version of https://meriyah.github.io/meriyah/ is v4.3.4
There was a problem hiding this comment.
There is a specific test for this case https://github.com/surfly/meriyah/pull/29/files#diff-9da4b71cb6cc09891f2ad28992c7cf414cf7c39d26adcc67c66069f22d4e1684R4132 and two more for other main cases.
There was a problem hiding this comment.
You're right, online version of the parser is outdated.
But the test cases are actually working in old versions, that caused the confusion:
// string from the tests - parsed before the fix
String.raw`{\rtf1adeflang1025ansiansicpg1252\\uc1`;
// string from the ticket - only works after the fix
String.raw`{\rtf1\adeflang1025\ansi\ansicpg1252\uc1`;Can we add second string to the tests?
There was a problem hiding this comment.
Aha, I see your confusion and it's tricky indeed! I must have added an additional '\' because otherwise a js string can't be created:
There was a problem hiding this comment.
Not as a regular string, but String.raw actually accepts it.
The PR fixes these two issues:
https://github.com/surfly/it/issues/4752
https://github.com/surfly/it/issues/4815
In general the PR fixes these two corner cases with template strings: