Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix property double assignment #26

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Fix property double assignment #26

merged 4 commits into from
Nov 1, 2023

Conversation

DimaIT
Copy link
Member

@DimaIT DimaIT commented Oct 31, 2023

Double assignment is not parsed correctly in class' property definition.

class A { b = c = d; } is parsed like class A { b = c; = d; } which is not a valid AST.

This PR fixes it along with other possible assignment operators.

@DimaIT DimaIT requested review from qguv and ypapouski October 31, 2023 17:34
@DimaIT DimaIT requested review from pmenichelli and removed request for qguv November 1, 2023 09:45
ypapouski
ypapouski approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@ypapouski ypapouski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DimaIT DimaIT merged commit 2ae782d into master Nov 1, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmenichelli pmenichelli pmenichelli approved these changes

@ypapouski ypapouski ypapouski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DimaIT @pmenichelli @ypapouski