Skip to content

Commit

Permalink
Added warning after PVC creation
Browse files Browse the repository at this point in the history
Partially resolve kubernetes#376 and kubernetes#345
Added warning, such that PV should be created before PVC or
if dynamic provision is there, no need to create PV.
  • Loading branch information
surajnarwade committed Apr 4, 2017
1 parent a24084d commit aa30acc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
7 changes: 5 additions & 2 deletions pkg/transformer/kubernetes/kubernetes.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ type Kubernetes struct {
// used when undeploying resources from kubernetes
const TIMEOUT = 300

//default size of Persistent Volume Claim
const PVCRequestSize = "100Mi"

// list of all unsupported keys for this transformer
// Keys are names of variables in kobject struct.
// this is map to make searching for keys easier
Expand Down Expand Up @@ -241,7 +244,7 @@ func (k *Kubernetes) initIngress(name string, service kobject.ServiceConfig, por

// CreatePVC initializes PersistentVolumeClaim
func (k *Kubernetes) CreatePVC(name string, mode string) (*api.PersistentVolumeClaim, error) {
size, err := resource.ParseQuantity("100Mi")
size, err := resource.ParseQuantity(PVCRequestSize)
if err != nil {
return nil, errors.Wrap(err, "resource.ParseQuantity failed, Error parsing size")
}
Expand Down Expand Up @@ -664,7 +667,7 @@ func (k *Kubernetes) Deploy(komposeObject kobject.KomposeObject, opt kobject.Con
if err != nil {
return err
}
log.Infof("Successfully created PersistentVolumeClaim: %s", t.Name)
log.Infof("Successfully created PersistentVolumeClaim: %s of size %s. PVC's will not work unless a PersistentVolume has been created.", t.Name, PVCRequestSize)
case *extensions.Ingress:
_, err := client.Ingress(namespace).Create(t)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion pkg/transformer/openshift/openshift.go
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ func (o *OpenShift) Deploy(komposeObject kobject.KomposeObject, opt kobject.Conv
if err != nil {
return err
}
log.Infof("Successfully created PersistentVolumeClaim: %s", t.Name)
log.Infof("Successfully created PersistentVolumeClaim: %s of size %s. PVC's will not work unless a PersistentVolume has been created.", t.Name, kubernetes.PVCRequestSize)
case *routeapi.Route:
_, err := oclient.Routes(namespace).Create(t)
if err != nil {
Expand Down

0 comments on commit aa30acc

Please sign in to comment.