Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hyperspace to VDB table #371

Merged
merged 11 commits into from
May 28, 2024

Conversation

YanivHyper-Space
Copy link
Contributor

Add Hyperspace to the list of search DB

@dhruv-anand-aintech dhruv-anand-aintech changed the title Add files via upload Add Hyperspace to VDB table May 3, 2024
@dhruv-anand-aintech dhruv-anand-aintech marked this pull request as ready for review May 3, 2024 12:04
@dhruv-anand-aintech dhruv-anand-aintech requested a review from a team as a code owner May 3, 2024 12:04
Copy link
Contributor

@dhruv-anand-aintech dhruv-anand-aintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the comments. Thanks

docs/tools/vdb_table/data/Hyperspace.json Show resolved Hide resolved
"vector_launch_year": 2023,
"metadata_filter": {
"support": "full",
"source_url": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide a link to the documentation for this feature here

docs/tools/vdb_table/data/Hyperspace.json Outdated Show resolved Hide resolved
docs/tools/vdb_table/data/Hyperspace.json Outdated Show resolved Hide resolved
},
"pricing": {
"value": "Per usage",
"source_url": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide a link to pricing details

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just following up again. I fixed everything I can. Could you please approve the pull request?

"comment": ""
},
"in_process": {
"support": "full",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for a DB that runs on the client itself, not for cloud-based DBs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hyperspace is both cloud and on prem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, in-process means it should be running locally in the same process as where it is being used. This is different from it running on-prem in a separate server/process. You can have a look at the other DBs which have this marked and confirm if Hyperspace has this feature. If not, I'll send a PR to unset this field.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please unset it. Hyperspace does not support it.

Thank you for the help

docs/tools/vdb_table/data/Hyperspace.json Outdated Show resolved Hide resolved
docs/tools/vdb_table/data/Hyperspace.json Outdated Show resolved Hide resolved
docs/tools/vdb_table/data/Hyperspace.json Show resolved Hide resolved
Hi!
I answered and modified everything I could. I don't have a link to pricing and license for now. I'll update ASAP
Copy link
Contributor Author

@YanivHyper-Space YanivHyper-Space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
What else is missing for the PR approval?

@YanivHyper-Space
Copy link
Contributor Author

please address the comments. Thanks

I addreeses all comments. Only exception is license, which I don't have a link for

@dhruv-anand-aintech
Copy link
Contributor

Hi @YanivHyper-Space, sorry for the delay. One of my comments remained un-submitted by mistake. I've addressed it myself, and I can see that the other fields are fine.

I'm merging this now.

Please add documentation source links for the fields that have it missing as soon as you get them. Thanks

@dhruv-anand-aintech dhruv-anand-aintech merged commit 3f2d194 into superlinked:main May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants