-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hyperspace to VDB table #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address the comments. Thanks
"vector_launch_year": 2023, | ||
"metadata_filter": { | ||
"support": "full", | ||
"source_url": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please provide a link to the documentation for this feature here
}, | ||
"pricing": { | ||
"value": "Per usage", | ||
"source_url": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please provide a link to pricing details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just following up again. I fixed everything I can. Could you please approve the pull request?
"comment": "" | ||
}, | ||
"in_process": { | ||
"support": "full", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is for a DB that runs on the client itself, not for cloud-based DBs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyperspace is both cloud and on prem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, in-process means it should be running locally in the same process as where it is being used. This is different from it running on-prem in a separate server/process. You can have a look at the other DBs which have this marked and confirm if Hyperspace has this feature. If not, I'll send a PR to unset this field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please unset it. Hyperspace does not support it.
Thank you for the help
Hi! I answered and modified everything I could. I don't have a link to pricing and license for now. I'll update ASAP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
What else is missing for the PR approval?
I addreeses all comments. Only exception is license, which I don't have a link for |
Hi @YanivHyper-Space, sorry for the delay. One of my comments remained un-submitted by mistake. I've addressed it myself, and I can see that the other fields are fine. I'm merging this now. Please add documentation source links for the fields that have it missing as soon as you get them. Thanks |
Add Hyperspace to the list of search DB