fix: remaining SSL connections that need to set verify_none option

VERSION

@@ -1 +1 @@
-2.3.7
+2.3.8

lib/supavisor/client_handler.ex

@@ -867,12 +867,16 @@ defmodule Supavisor.ClientHandler do
   @spec get_secrets(map, String.t()) :: {:ok, {:auth_query, fun()}} | {:error, term()}
   def get_secrets(%{user: user, tenant: tenant}, db_user) do
     ssl_opts =
-      if tenant.upstream_ssl and tenant.upstream_verify == "peer" do
+      if tenant.upstream_ssl and tenant.upstream_verify == :peer do
         [
-          {:verify, :verify_peer},
-          {:cacerts, [Helpers.upstream_cert(tenant.upstream_tls_ca)]},
-          {:server_name_indication, String.to_charlist(tenant.db_host)},
-          {:customize_hostname_check, [{:match_fun, fn _, _ -> true end}]}
+          verify: :verify_peer,
+          cacerts: [Helpers.upstream_cert(tenant.upstream_tls_ca)],
+          server_name_indication: String.to_charlist(tenant.db_host),
+          customize_hostname_check: [{:match_fun, fn _, _ -> true end}]
+        ]
+      else
+        [
+          verify: :verify_none
         ]
       end
 
@@ -890,7 +894,7 @@ defmodule Supavisor.ClientHandler do
         ],
         queue_target: 1_000,
         queue_interval: 5_000,
-        ssl_opts: ssl_opts || []
+        ssl_opts: ssl_opts
       )
 
     try do

lib/supavisor/helpers.ex

@@ -30,10 +30,14 @@ defmodule Supavisor.Helpers do
       ssl_opts =
         if upstream_ssl? and params["upstream_verify"] == "peer" do
           [
-            {:verify, :verify_peer},
-            {:cacerts, [upstream_cert(params["upstream_tls_ca"])]},
-            {:server_name_indication, String.to_charlist(params["db_host"])},
-            {:customize_hostname_check, [{:match_fun, fn _, _ -> true end}]}
+            verify: :verify_peer,
+            cacerts: [upstream_cert(params["upstream_tls_ca"])],
+            server_name_indication: String.to_charlist(params["db_host"]),
+            customize_hostname_check: [{:match_fun, fn _, _ -> true end}]
+          ]
+        else
+          [
+            verify: :verify_none
           ]
         end
 
@@ -50,7 +54,7 @@ defmodule Supavisor.Helpers do
           ],
           queue_target: 1_000,
           queue_interval: 5_000,
-          ssl_opts: ssl_opts || []
+          ssl_opts: ssl_opts
         )
 
       check =

lib/supavisor/secret_checker.ex

@@ -36,12 +36,16 @@ defmodule Supavisor.SecretChecker do
 
   def handle_continue(:init_conn, %{auth: auth} = state) do
     ssl_opts =
-      if auth.upstream_ssl and auth.upstream_verify == "peer" do
+      if auth.upstream_ssl and auth.upstream_verify == :peer do
         [
-          {:verify, :verify_peer},
-          {:cacerts, [Helpers.upstream_cert(auth.upstream_tls_ca)]},
-          {:server_name_indication, auth.host},
-          {:customize_hostname_check, [{:match_fun, fn _, _ -> true end}]}
+          verify: :verify_peer,
+          cacerts: [Helpers.upstream_cert(auth.upstream_tls_ca)],
+          server_name_indication: auth.host,
+          customize_hostname_check: [{:match_fun, fn _, _ -> true end}]
+        ]
+      else
+        [
+          verify: :verify_none
         ]
       end
 
@@ -59,7 +63,7 @@ defmodule Supavisor.SecretChecker do
         ],
         queue_target: 1_000,
         queue_interval: 5_000,
-        ssl_opts: ssl_opts || []
+        ssl_opts: ssl_opts
       )
 
     # kill the postgrex connection if the current process exits unexpectedly