Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not verify TLS cert when connecting to the DB #603

Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix: do not verify TLS cert when connecting to the DB #603

merged 1 commit into from
Feb 21, 2025
+4 −1

Conversation

hauleth
Copy link
Member

@hauleth hauleth commented Feb 21, 2025

No description provided.

@hauleth hauleth requested a review from a team as a code owner February 21, 2025 12:13
@hauleth
Copy link
Member Author

hauleth commented Feb 21, 2025

To clarify, it is safe, as it is how it was working in OTP 25. OTP 26 or 27 changed that to default to :verify_peer. This forces old behaviour (as otherwise it will fail). I wasn't sure if I can use OS provided root certs to verify that certificate, so I set it to :verify_none. This still uses secure communication.

@hauleth hauleth merged commit fae3576 into main Feb 21, 2025
7 of 8 checks passed
@hauleth hauleth deleted the do-not-verify-tls-cert branch February 21, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipecabaco filipecabaco filipecabaco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hauleth @filipecabaco