Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom-metadata, exists, info methods #1023

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Vinzent03
Copy link
Collaborator

What kind of change does this PR introduce?

feature

What is the current behavior?

No support for specifying metadata for files when uploading and missing info and exists methods.

What is the new behavior?

Support specifying metadata when uploading files.

Additional context

close #1021
js pr

@Vinzent03
Copy link
Collaborator Author

Currently waiting for an answer on supabase/storage#541 because I'm unsure about the correct types of the FileObjectV2 class.

@Vinzent03 Vinzent03 changed the title feat: custom-metadata, exists, info methods feat: Custom-metadata, exists, info methods Sep 10, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13140802025

Details

  • 48 of 50 (96.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 73.852%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/storage_client/lib/src/fetch.dart 21 22 95.45%
packages/storage_client/lib/src/types.dart 14 15 93.33%
Files with Coverage Reduction New Missed Lines %
packages/storage_client/lib/src/fetch.dart 1 94.06%
Totals Coverage Status
Change from base Build 13051463855: 0.1%
Covered Lines: 2799
Relevant Lines: 3790

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for custom metadata on storage objects missing
2 participants