Drop extra nixpkgs - #2388
Draft
mmlb wants to merge 3 commits into
Draft
Conversation
mmlb
force-pushed
the
push-wruxlypntvyq
branch
from
August 21, 2026 20:02
18e074a to
67382c6
Compare
PostgreSQL Extension Dependency Analysis: PR #2388
SummaryThe following extensions have dependencies that underwent MAJOR version updates:
Full Analysis ResultsPostgreSQL 15 Extension DependenciesExtension: pg_net
Raw Dependency TreePostgreSQL 17 Extension DependenciesExtension: pg_net
Raw Dependency TreeOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2388
SummaryThe following packages underwent MAJOR version updates:
Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
mmlb
force-pushed
the
push-wruxlypntvyq
branch
from
August 24, 2026 18:02
67382c6 to
c080c7d
Compare
v8 was being defined outside of the build function which is not `rec` so
all the refs to it as v8 or `${v8}` were to v8_oldstable. This is
actually fine since we don't have any plv8 >= 3.2 but would be wrong if
we ever update.
While here use nixpkgs' nicer lib.versionOlder instead of
builtins.compareVersions and avoid repeating the same logic (DRY)
multiple times..
Avoid fetching and copying a second nixpkgs input and its runtime dependencies into the image. Define curl 8.6 and V8 9.7 against our current nixpkgs instead, while retaining the required compatibility patches. Mark both outdated packages as insecure so their maintenance risk remains explicit. Assisted-by: OpenCode:openai/gpt-5.6-sol
mmlb
force-pushed
the
push-wruxlypntvyq
branch
from
August 25, 2026 18:38
c080c7d to
3f42315
Compare
Update nix-eval-jobs so it builds against the current nixpkgs, then redirect its nixpkgs input to ours. This avoids fetching and copying a second nixpkgs input while keeping nix-eval-jobs version-compatible.
mmlb
force-pushed
the
push-wruxlypntvyq
branch
from
August 25, 2026 18:49
3f42315 to
3cb3a6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
We have 3 copies of nixpkgs in our flake, 2 are used in our outputs and the other is for nix-eval-jobs.
What is the new behavior?
Only one nixpkgs.
Additional context
Dropping unnecessary nixpkgs is nice for a few reasons the most obvious is less needs to be fetch and copied into the store at build time so has some benefits there. The big benefit is in dropping nixpkgs-oldstable which was used for curl v8.6 and v8, but that also ends up "duplicating" all the dependencies (libc + others) with the rest of the tree. Nix handles that fine but bloats our final image. Instead of whole nixpkgs and deps we can just build those old packages on our new nixpkgs and get the functionality without the bloat.