fix: locking the tables for too much time #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the worker process the queue for a long time, it will preventing operations like TRUNCATE or VACUUM FULL from completing. This is because it acquires an AccessShareLock on the extension tables and only releases it once it goes to sleep. Now we use `ConditionalLockRelationOid` and unlock the tables at the end of each transaction, allowing VACUUM FULL or TRUNCATE to finish fast.
steve-chavez
force-pushed
the
fix-truncate
branch
from
f06da9b to
8a12d6f
Compare
laurenceisla
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the worker process the queue for a long time, it will preventing operations like TRUNCATE or VACUUM FULL from completing.
This is because it acquires an AccessShareLock on the extension tables and only releases it once it goes to sleep.
Now we use
ConditionalLockRelationOidand unlock the tables at the end of each transaction, allowing VACUUM FULL or TRUNCATE to finish fast.