add code coverage workflow #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samrose
reviewed
Jan 23, 2025
.github/workflows/coverage.yml
Outdated
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| path-to-lcov: lcov.info | ||
| debug: true |
There was a problem hiding this comment.
I guess git doesn't like it when you don't have a newline at end of file.
samrose
reviewed
Jan 23, 2025
.github/workflows/coverage.yml
Outdated
| sudo chmod a+rwx `/usr/lib/postgresql/16/bin/pg_config --pkglibdir` `/usr/lib/postgresql/16/bin/pg_config --sharedir`/extension /var/run/postgresql/ | ||
|
|
||
| - run: cargo install cargo-pgrx --version 0.12.6 | ||
| - run: cargo pgrx init --pg16 /usr/lib/postgresql/16/bin/pg_config |
There was a problem hiding this comment.
Will it matter if this code coverage check is only done on pg 16 but that our targets are pg15 and 17 downstream?
There was a problem hiding this comment.
No, it shouldn't matter because this is just generating code coverage which for all practical purposes will be the same whichever pg version we use here.
samrose
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new code coverage workflow to send code coverage to coveralls