compliance with the principle of DRY in the email.py file #689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file: https://github.com/sunscrapers/djoser/blob/master/djoser/email.py
In the get_context_data() method of three of the classes, many lines of code are repeated. (Dont Repeat Yourself)
If we want to add a line of code, we have to do this 3 times, it is definitely difficult to maintain this code.
I wrote a mixin in the email_mixins.py file and put these duplicates in it and inherited the desired classes from it.
Also, the common part of the code that caused this to be repeated 3 times was the different context["url"], so I solved this problem by adding a parameter to the class.