Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make RhessiLoader compatible with legacy fitter args #181

Merged
merged 7 commits into from
Feb 1, 2025

Conversation

settwi
Copy link
Contributor

@settwi settwi commented Jan 27, 2025

Fixes #180

@settwi
Copy link
Contributor Author

settwi commented Jan 27, 2025

@ianan can you try running your script with this branch? you can install it like so:

pip install git+https://github.com/settwi/sunkit-spex.git@rhessi-legacy-compatibility

@samaloney
Copy link
Collaborator

I'd say this does need change log?

@settwi
Copy link
Contributor Author

settwi commented Jan 31, 2025

I'd say this does need change log?

fair enough :p

@settwi settwi removed the No Changelog Entry Needed Skip all changelog checks. label Jan 31, 2025
@settwi settwi marked this pull request as ready for review January 31, 2025 18:55
@settwi settwi requested review from samaloney and KriSun95 January 31, 2025 19:06
@settwi settwi marked this pull request as draft January 31, 2025 19:12
@settwi settwi force-pushed the rhessi-legacy-compatibility branch from cfe44ba to 9c9a8e3 Compare January 31, 2025 19:52
@settwi settwi marked this pull request as ready for review January 31, 2025 19:58
@KriSun95 KriSun95 merged commit 44a7611 into sunpy:main Feb 1, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RHESSI loader has incompatibilities with "legacy" portion of fitting code
3 participants