Set fvth flux to 0 for input energies above CHIANTI energy grid #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanRyanIrish Could you have a quick look through the changes please? I haven't changed any of the actual code that calculates the flux; I have only updated the warnings/errors. |
samaloney
approved these changes
Jan 23, 2025
samaloney
approved these changes
Jan 28, 2025
|
are there ant f_vth tests that try to use the zeroed count values above the grid energies? |
settwi
approved these changes
Jan 28, 2025
|
@samaloney and @natsat0919 are u happy with the tests? i added a check on |
|
@settwi looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #177.
If some of the thermal model input energies are above the CHIANTI energy grid, the flux for these is set to 0 and a warning is shown (originally a ValuError was raised). This should be similar to what OSPEX does. At these >200 keV energies the contribution from the thermal model is negligible so setting the flux to 0 shouldn't be a problem.
If some of the input energies are below the CHIANTI energy grid, then a ValueError is raised.