Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add albedo correction #161

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Add albedo correction #161

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4a5a544
First draft
samaloney Sep 12, 2024
087ea16
eh not sure
samaloney Sep 19, 2024
f7fc55d
Speed up albedo correction, add AlbedoModel
natsat0919 Dec 19, 2024
503ff07
WIP
samaloney Sep 26, 2024
b5c8895
Tidyup, tests and docs
samaloney Dec 20, 2024
6ee7756
Add model and tidy up code
samaloney Dec 27, 2024
9e0137c
Fix test issue
samaloney Dec 27, 2024
b15fe40
Unit handling now works with Scipy fitting
jajmitchell Jan 10, 2025
7cd2333
Added in unit handling for Astropy
jajmitchell Jan 13, 2025
bce28e6
Astropy fitting is now fully functional
jajmitchell Jan 14, 2025
da1407c
Functions moved out of class, fitting works.
jajmitchell Jan 20, 2025
725001c
Update sunkit_spex/models/physical/albedo.py
jajmitchell Jan 21, 2025
ac154bc
Update sunkit_spex/models/physical/albedo.py
jajmitchell Jan 22, 2025
b9299a8
Update sunkit_spex/models/physical/albedo.py
samaloney Jan 22, 2025
737a7ff
Update sunkit_spex/models/physical/albedo.py
samaloney Jan 22, 2025
a5ef1e2
Ruff fixes
samaloney Jan 22, 2025
fcdbc09
Update spectrum example for NDCube docstring change
samaloney Jan 22, 2025
12b6bbb
Fix doctest issue disable on older version of NDCube
samaloney Jan 22, 2025
a93d551
Only skip doctest on specific class
samaloney Jan 23, 2025
2c4069e
Update sunkit_spex/models/physical/albedo.py
jajmitchell Jan 30, 2025
ea98415
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sunkit_spex/models/physical/albedo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)

def evaluate(self, spectrum, theta, anisotropy):
albedo_matrix = get_albedo_matrix(self.energy_edges, theta, anisotropy)
albedo_matrix = get_albedo_matrix(self.energy_edges, self.theta, anisotropy)
samaloney marked this conversation as resolved.
Show resolved Hide resolved
return spectrum + spectrum @ albedo_matrix


Expand Down
Loading