Fitter legacy #137
Merged
Fitter legacy #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog/137.breaking.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Rename of `sunxspex_fitting` module tp `fitting_legacy` and added new `fitting` module. | |||
There was a problem hiding this comment.
Suggested change
| Rename of `sunxspex_fitting` module tp `fitting_legacy` and added new `fitting` module. | |
| Rename of `sunxspex_fitting` module to `fitting_legacy` and added new `fitting` module. |
There was a problem hiding this comment.
Also the new fitter module hasn't been added which is fine but if not going to do in this PR then probably remove from change log.
There was a problem hiding this comment.
I didn't realise empty directories did not get added. I have now managed to get the fitting module to be included.
added 6 commits
February 20, 2024 17:51
samaloney
force-pushed
the
fitter-legacy
branch
from
5c209ae to
f993869
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage ? 55.81%
=======================================
Files ? 20
Lines ? 3166
Branches ? 0
=======================================
Hits ? 1767
Misses ? 1399
Partials ? 0 ☔ View full report in Codecov by Sentry. |
samaloney
approved these changes
Feb 20, 2024
added 2 commits
February 20, 2024 17:54
|
I've made changes to the changelog and also added the |
KriSun95
added a commit
to KriSun95/sunkit-spex
that referenced
this pull request
Mar 4, 2024
* Changed fittter_legacy module to fitting_legacy and added new fitting module --------- Co-authored-by: Kristopher Cooper <[email protected]> Co-authored-by: Shane Maloney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
sunxspex_fittingtofitting_legacyand adding newfittingmodule.