We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When the RhessiLoader got moved to extern some of the methods/properties got renamed or modified.
RhessiLoader
extern
Thanks to @ianan for pointing this out. The "legacy" code should continue to work even if the loader has been moved to extern
Here's a list of things that we need to support. Most can be fixed with simple patches. The old names should probably be given deprecation warnings.
Fitter
data2data_minus_background
background_subtract
start_event_time
end_event_time
start_background_time
end_background_time
I think those are the changes between the previous RHESSI loader and the current. I'll open a PR shortly which addresses these.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Describe the bug
When the
RhessiLoader
got moved toextern
some of the methods/properties got renamed or modified.Thanks to @ianan for pointing this out. The "legacy" code should continue to work even if the loader has been moved to
extern
Here's a list of things that we need to support. Most can be fixed with simple patches. The old names should probably be given deprecation warnings.
Fitter
doesn't work for RHESSIdata2data_minus_background
got renamed tobackground_subtract
start_event_time
end_event_time
start_background_time
end_background_time
I think those are the changes between the previous RHESSI loader and the current. I'll open a PR shortly which addresses these.
The text was updated successfully, but these errors were encountered: