Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHESSI loader has incompatibilities with "legacy" portion of fitting code #180

Open
8 tasks done
settwi opened this issue Jan 27, 2025 · 0 comments · May be fixed by #181
Open
8 tasks done

RHESSI loader has incompatibilities with "legacy" portion of fitting code #180

settwi opened this issue Jan 27, 2025 · 0 comments · May be fixed by #181
Labels
Bug Probably a bug. Effort Low Requires a small time investment.

Comments

@settwi
Copy link
Contributor

settwi commented Jan 27, 2025

Describe the bug

When the RhessiLoader got moved to extern some of the methods/properties got renamed or modified.

Thanks to @ianan for pointing this out. The "legacy" code should continue to work even if the loader has been moved to extern

Here's a list of things that we need to support. Most can be fixed with simple patches. The old names should probably be given deprecation warnings.

  • Passing in the spectrum and SRM FITS files to Fitter doesn't work for RHESSI
  • the property data2data_minus_background got renamed to background_subtract
  • Time-related properties
    • start_event_time
    • end_event_time
    • start_background_time
    • end_background_time
    • Frankly--I think these should be updated in pairs, but we can support the individual getters/setters
  • Spectrum energy bounds don't get respected when set near the edges
    • Not sure if this was ever the case, but we can support it here if desired.

I think those are the changes between the previous RHESSI loader and the current. I'll open a PR shortly which addresses these.

@settwi settwi added Bug Probably a bug. Effort Low Requires a small time investment. labels Jan 27, 2025
@settwi settwi linked a pull request Jan 27, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Probably a bug. Effort Low Requires a small time investment.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant