Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make app.py clean and remove repeat imports #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make app.py clean and remove repeat imports #88

wants to merge 1 commit into from

Conversation

abdulmuizz0903
Copy link

Assalamualaikum

  1. A module was imported twice

    • extensions(from mail module) was imported twice so I corrected this.

  2. You were using a bad practice of importing modules in the middle.

    • You were importing modules in between of the code which is considered as a bad practice. So I imported all of them at start.

May Allah bless you

@abdulmuizz0903
Make app.py clean and remove repeat imports
4cba81c 
Assalamualaikum,

I made this code clean and disciplined as importing modules  at start is a practice in python which is followed by almost all Developers.  And extensions(from mail) was imported twice so I corrected this. 

May Allah bless you.
@edrisranjbar
Copy link

I think this commit is good and should be merged! Thanks @abdulmuizz0903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdulmuizz0903 @edrisranjbar