Add unit tests for pkg/diagnose #1566
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While errors were logged, misuse of the Tracker prevented an error from being propagated to fail the command. Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
Also fixed issues found by the tests and streamlined the production code a bit to increase coverage. Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
...to use the testSuccess, testFailure et al functions. Signed-off-by: Tom Pantelis <[email protected]>
...to use the testSuccess, testFailure et al functions. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
Jaanki,
Oats87,
aswinsuryan,
dfarrell07,
maayanf24,
skitt,
sridhargaddam and
vthapar
as code owners
Contributor
|
🤖 Created branch: z_pr1566/tpantelis/diagnose_ut |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of commits that adds unit tests for the various files in pkg/diagnose. Also, fixes issues found and makes enhancements to reuse code and increases code coverage.