Skip to content

Conversation

@jeddy3
Copy link
Member

@jeddy3 jeddy3 commented Nov 24, 2025

Which issue, if any, is this issue related to?

Closes #512

Is there anything in the PR that needs further explanation?

A couple of things to note:

  • the tests run in sequence to speed things up, as the initial server start takes a while
  • there are a few workarounds because of how Monaco works, including using element names to locate the key parts of the app

You can use npx playwright test --ui locally to see the traces of the tests.

@jeddy3 jeddy3 requested a review from a team as a code owner November 24, 2025 13:37
@netlify
Copy link

netlify bot commented Nov 24, 2025

Deploy Preview for chimerical-trifle-8d3c21 ready!

Name Link
🔨 Latest commit d3ea07a
🔍 Latest deploy log https://app.netlify.com/projects/chimerical-trifle-8d3c21/deploys/69259b6bd3245800086da4e1
😎 Deploy Preview https://deploy-preview-513--chimerical-trifle-8d3c21.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I love the E2E addition. 👍🏼

Overall LGTM, but I've left a few minor comments.

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I've confirmed the uploaded HTML test report. LGTM 👍🏼


By the way, it seems a good practice to add e2e to status checks in the branch ruleset:
Image
(it's not a blocker for this PR, though)

@jeddy3 jeddy3 merged commit b355425 into main Nov 25, 2025
11 checks passed
@jeddy3 jeddy3 deleted the add-e2e branch November 25, 2025 12:42
@jeddy3
Copy link
Member Author

jeddy3 commented Nov 25, 2025

Thank you for the review 🙇


By the way, it seems a good practice to add e2e to status checks in the branch ruleset:

Done.


I remembered to remove the bot from the commit message:

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

It was added by this commit.

@ybiquitous
Copy link
Member

I remembered to remove the bot from the commit message:

This is pretty hard to notice. Let's not mind too much (I might fall into the hole, too). 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Add e2e tests

3 participants