-
-
Notifications
You must be signed in to change notification settings - Fork 11
Add e2e tests for happy paths #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for chimerical-trifle-8d3c21 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
ybiquitous
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I love the E2E addition. 👍🏼
Overall LGTM, but I've left a few minor comments.
Co-authored-by: Masafumi Koba <[email protected]>
ybiquitous
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Thank you for the review 🙇
Done. I remembered to remove the bot from the commit message: It was added by this commit. |
This is pretty hard to notice. Let's not mind too much (I might fall into the hole, too). 😅 |

Closes #512
A couple of things to note:
You can use
npx playwright test --uilocally to see the traces of the tests.