Add toolbar with report-bug and copy-link actions #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chimerical-trifle-8d3c21 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ybiquitous
reviewed
Nov 24, 2025
Member
ybiquitous
left a comment
ybiquitous
left a comment
There was a problem hiding this comment.
I appreciate that you have implemented my old request. Amazing! 👍🏼
This PR looks great overall to me, but I'd like to request a few minor improvements. I don't think they would block the merge. 😃
Co-authored-by: Masafumi Koba <[email protected]>
Member
Author
|
@ybiquitous Thanks for the review. I've committed both suggestions.
No worries. I often find myself using the demo to either report bugs or reproduce issues, so the new actions make my life easier 😄 |
Member
💯 definitely! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #423
A barebones implementation of the two toolbar actions mentioned in the issue.
It adds
<sd-toolbar>to the bottom of the app and places<sd-report>and<sd-copy-link>within it.<sd-report>appends four bits of query data to the base "report a bug" link:reproduce-bug= style codestylelint-configuration= config codestylelint-run= demo URL as linkstylelint-version= installed deps<sd-copy-link>simply puts the current URL into the clipboardCode is wrapped in appropriate markdown code fences.
Example template:
I've tried to match the patterns from the existing components as much as possible. Although, as I mentioned in an earlier issue, I'm not very familiar with the codebase and may have missed something.