Allow Passing Shadow Root as Sheet Target #4309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantizor
approved these changes
May 11, 2024
|
@quantizor sounds good to me! Do you think it should live in |
src/types is good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
@types/styled-components, thetargetprop ofStyleSheetManagerallows passing aShadowRoot(see here).As I'm not familiar with this codebase, I started from the change to
IStyleSheetManager, then fixed any type errors that surfaced. @quantizor please let me know if you see any problems with what I've done here, or if you know of a reason why theShadowRootoption wasn't carried over into v6!