add a failing test case for .attrs() #4306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonNiklasson
force-pushed
the
anton/attrs-failing-test
branch
from
3af58b6
to
500720f
Compare
AntonNiklasson
force-pushed
the
anton/attrs-failing-test
branch
from
500720f
to
e2b8b04
Compare
|
@quantizor I've attached a failing test case here, but I understand we can't just merge that without a fix. I'm afraid I'm not skilled enough to fix it myself though. I'm not sure how to proceed here, this is probably the main blocker for us to migrate to v6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're running in to some issues in our codebase on
6.1.9. I managed to reproduce a minimal case that fails with the improved types from #4288.@uhyo could you take a look at this? Perhaps that gives you a clue on how to fix it?