This repository has been archived by the owner on Aug 6, 2024. It is now read-only.
Optimize mass sending of emails for meeting notifications #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to optimize the delay for creating a meeting Before this commit, it took 9.90sec for ~40 emails. Examine if this runs up against rate limits
Appears that this patch does not lead to rate limit issues, even on the largest test data set, Red Cross (> 300 members). Add this functionality to alterMeeting, which *timed out after 1 minute* due to how long the unpatched code took.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduling meetings for large clubs (~200-300+ members) will lead to NetworkErrors due to the request taking over 1 minute to resolve.
This is because we send out all emails in sequence, rather than in parallel using
Promise.all(). By leveraging asynchronous functions to their full potential, we can reduce the response time for all clubs by a factor of 1/2 or better.Here some average request times (in seconds, as measured by Firefox Network Monitor)