Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

Member requirement #737

Merged
merged 25 commits into from
Oct 1, 2023
Merged

Member requirement #737

merged 25 commits into from
Oct 1, 2023

Conversation

randysim
Copy link
Contributor

No description provided.

@restyled-io restyled-io bot mentioned this pull request Aug 23, 2023
Closed
@TheEgghead27
Correct migration default data
3a7e7b3 
In addition:
- Add undo script to package.json for schema migrations
- Run prettier
TheEgghead27
TheEgghead27 suggested changes Aug 27, 2023
View reviewed changes
Copy link
Member

@TheEgghead27 TheEgghead27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!
I've addressed the migrations issue myself, but I think we should discuss whether or not we should make the membership check a function, especially since we may want to send club leaders a notice when their club gets locked.

src/graphql/resolvers/Mutation/approveMembershipRequest.js Outdated Show resolved Hide resolved
src/googleApis/authenticate.js Outdated Show resolved Hide resolved
src/database/models/settings.js Outdated Show resolved Hide resolved
src/graphql/resolvers/Mutation/approveCharterFields.js Show resolved Hide resolved
src/graphql/resolvers/Mutation/approveMembershipRequest.js Outdated Show resolved Hide resolved
@TheEgghead27
Import ForbiddenError
069c713
@TheEgghead27
Compartmentalize user minimum checks
558ed37 
Adds email notifications of state changes for users
@TheEgghead27
Copy link
Member

Codacy checks are all insignificant, merging into beta branch for test deployment onto beta.api.stuyactivities.org

@TheEgghead27 TheEgghead27 mentioned this pull request Sep 4, 2023
Merged
@restyled-io restyled-io bot mentioned this pull request Sep 24, 2023
Closed
@restyled-io restyled-io bot mentioned this pull request Sep 24, 2023
Closed
@restyled-io restyled-io bot mentioned this pull request Oct 1, 2023
Merged
TheEgghead27
TheEgghead27 approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@TheEgghead27 TheEgghead27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After extensive bug fixing and feature improvements, this appears to be ready for mainline.

Test on the beta site by oscillating from 20 +- 1

randysim
randysim commented Oct 1, 2023
View reviewed changes
Copy link
Contributor Author

@randysim randysim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@randysim randysim merged commit 91f95c9 into master Oct 1, 2023
1 of 2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TheEgghead27 TheEgghead27 TheEgghead27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randysim @TheEgghead27 @restyled-commits