-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Re #5 - Parameter schema + refactor for Unit and Value schemas #8
base: main
Are you sure you want to change the base?
WIP: Re #5 - Parameter schema + refactor for Unit and Value schemas #8
Conversation
20fe9a1
to
dcfc579
Compare
@stuchalk So this one should be ready except needs MR #7 approved and merged first (will rebase this feature off those changes going in) This one re-writes the Unit and Value schema based on the need that arose with Parameter schema setup (and only realizing that by creating the tests 😁) Pretty happy though, it is checking for valid schema in the |
Work includes:
parameter
schemaunit
andvalue
schemascontext
->unit
->value
->parameter
) that arose with creating theparameter
schema. Needed scripting withjsonschema
package, not just CLIexamples/sections
as well as invalidating "bad" schema found in the tests themselves such as bad values and additional properties that shouldn't be there.Blocked by: MR #7 needs to be merged first so we can rebase off that work