Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Re #5 - Parameter schema + refactor for Unit and Value schemas #8

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

marshallmcdonnell
Copy link
Contributor

@marshallmcdonnell marshallmcdonnell commented Jun 17, 2019

Work includes:

  • Adds the parameter schema
  • Refactors the unit and value schemas
    • more DRY (Don't Repeat Yourself) using the definitions section
  • Switches to testing with pytest
    • Testing required using "linked" or "chained" schemas (i.e. context -> unit -> value -> parameter) that arose with creating the parameter schema. Needed scripting with jsonschema package, not just CLI
    • Includes testing valid JSON-LD in examples/sections as well as invalidating "bad" schema found in the tests themselves such as bad values and additional properties that shouldn't be there.

Blocked by: MR #7 needs to be merged first so we can rebase off that work

@marshallmcdonnell marshallmcdonnell changed the title Parameter schema Re #5 - Parameter schema Jun 17, 2019
@marshallmcdonnell marshallmcdonnell changed the title Re #5 - Parameter schema WIP: Re #5 - Parameter schema Aug 3, 2022
@marshallmcdonnell marshallmcdonnell changed the title WIP: Re #5 - Parameter schema WIP: Re #5 - Parameter schema + refactor for Unit and Value schemas Aug 3, 2022
@marshallmcdonnell
Copy link
Contributor Author

@stuchalk So this one should be ready except needs MR #7 approved and merged first (will rebase this feature off those changes going in)

This one re-writes the Unit and Value schema based on the need that arose with Parameter schema setup (and only realizing that by creating the tests 😁)

Pretty happy though, it is checking for valid schema in the examples/sections directory + validating "bad" schema too in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant