-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass TFM into Buildalyzer build #3185
base: master
Are you sure you want to change the base?
Conversation
Not sure of the link with issue #3181. We tried this in the past and it resulted in unexpected results when working on non trivial multitargeting project, such as library project targeting some At best, we could make this behavior an option, so user could reduce the initialization time when this is supported by the project, but It cannot be the default behavior. |
Yeah, I think this was #3038 as it caused issues with Polly. |
yes. @martincostello 's comment gave me the opportunity to look again at my resolution table and fix an error there. |
Ah! Thanks @martincostello and @dupdob for the context. Yeah that makes total sense. I've plugged in the NuGet I've tried to make it as graceful as possible, so if it comes back |
that was not my point. I am afraid this will not solve the issue mentioned in #3038: we do not know how framework selection work with project dependency resolution. Trying to force a framework for every single project will lead to undefined behvaviour. What problem are you trying to solve here? you should open an issue so we can discuss how to achieve the desired outcome |
Sure I'll create an issue to explain |
See here: phmonte/Buildalyzer#297 (comment)
and #3181 for context.
Passing the TFM into Buildalyzer prevents all TFMs being built for a multitarget project.