Make ImGui binds the fallback texture descriptor set when the recorded draw command ImTextureID is destroyed by ImGui_ImplVulkan_RemoveTexture. #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d draw command ImTextureID is destroyed by ImGui_ImplVulkan_RemoveTexture. It tracks the allocated/destroyed descriptor sets using std::unordered_set<VkDescriptorSet> and check their validity when executing ImGui_ImplVulkan_RenderDrawData(). It simplifies the asset ImGui texture descriptor set lifetime management (lifetime doesn't have to be retained using std::vector::resize() trick).
…ensure the proper destruction order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the ImGui's internal Vulkan backend by tracking the allocated/destroyed descriptor sets using
std::unordered_set<VkDescriptorSet>, and checking their validity when executingImGui_ImplVulkan_RenderDrawData(). This can simplify the ImGui texture descriptor set lifetime management by:SharedData::GltfAssetand can be managed by RAII allocation/destroying (and so do the skybox descriptor set).To ensure the allocated ImGui texture descriptor set is destroyed before
ImGui_ImplVulkan_Shutdown()call, ImGui context creation/destroying is reimplemented by RAII structureImGuiContextinMainApp.