removed blacklist code, now that this library supports multiple frame…

…work versions, getting around it is very trivial, closes #190
stripe · Jan 21, 2015 · 8eeae0f · 8eeae0f
1 parent d7ccb22
commit 8eeae0f
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 51 deletions.
diff --git a/src/Stripe.Tests/Stripe.Tests.csproj b/src/Stripe.Tests/Stripe.Tests.csproj
@@ -125,7 +125,6 @@
     <Compile Include="recipients\when_updating_a_recipient.cs" />
     <Compile Include="requestor\when_creating_a_request.cs" />
     <Compile Include="requestor\when_requesting_an_old_api_version.cs" />
-    <Compile Include="requestor\when_requesting_a_blacklisted_certificate.cs" />
     <Compile Include="requestor\when_requesting_a_mismatched_certificate.cs" />
     <Compile Include="subscriptions\when_changing_a_subscription_plan.cs" />
     <Compile Include="subscriptions\when_creating_a_subscription.cs" />

diff --git a/src/Stripe.Tests/requestor/when_requesting_a_blacklisted_certificate.cs b/src/Stripe.Tests/requestor/when_requesting_a_blacklisted_certificate.cs
diff --git a/src/Stripe/Infrastructure/Requestor.cs b/src/Stripe/Infrastructure/Requestor.cs
@@ -2,8 +2,6 @@
 using System.IO;
 using System.Net;
 using System.Text;
-using System.Net.Security;
-using System.Security.Cryptography.X509Certificates;
 
 namespace Stripe
 {
@@ -57,26 +55,6 @@ internal static WebRequest GetWebRequest(string url, string method, string apiKe
             return request;
         }
 
-        private static readonly string[] BlacklistedCertDigests = {
-            // api.stripe.com
-            "05C0B3643694470A888C6E7FEB5C9E24E823DC53",
-            // revoked.stripe.com
-            "5B7DC7FBC98D78BF76D4D4FA6F597A0C901FAD5C",
-        };
-
-        private static bool StripeCertificateVerificationCallback(Object sender, X509Certificate certificate, X509Chain chain, SslPolicyErrors sslPolicyErrors)
-        {
-            var certDigest = certificate.GetCertHashString();
-
-            if(Array.Exists(BlacklistedCertDigests, digest => digest.Equals(certDigest, StringComparison.OrdinalIgnoreCase)))
-                return false;
-
-            if(sslPolicyErrors == SslPolicyErrors.None)
-                return true;
-
-            return false;
-        }
-
         private static string GetAuthorizationHeaderValue(string apiKey)
         {
             var token = Convert.ToBase64String(Encoding.UTF8.GetBytes(string.Format("{0}:", apiKey)));
@@ -90,12 +68,8 @@ private static string GetAuthorizationHeaderValueBearer(string apiKey)
 
         private static string ExecuteWebRequest(WebRequest webRequest)
         {
-            var verificationCallback = new RemoteCertificateValidationCallback(StripeCertificateVerificationCallback);
-
             try
             {
-                ServicePointManager.ServerCertificateValidationCallback += verificationCallback;
-
                 using (var response = webRequest.GetResponse())
                 {
                     return ReadStream(response.GetResponseStream());
@@ -119,10 +93,6 @@ private static string ExecuteWebRequest(WebRequest webRequest)
 
                 throw;
             }
-            finally
-            {
-                ServicePointManager.ServerCertificateValidationCallback -= verificationCallback;
-            }
         }
 
         private static string ReadStream(Stream stream)