Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assertion that address is required for Klarna #10270

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

amk-stripe
Copy link
Collaborator

@amk-stripe amk-stripe commented Feb 26, 2025

Summary

Remove assertion that address is required for Klarna

Motivation

Test started failing, indicating that country is no longer required, so we don't need to assert on this anymore

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed          │        uncompressed        
          ├───────────┬───────────┬──────┼──────────┬──────────┬──────
 APK      │ old       │ new       │ diff │ old      │ new      │ diff 
──────────┼───────────┼───────────┼──────┼──────────┼──────────┼──────
      dex │   4.1 MiB │   4.1 MiB │  0 B │    9 MiB │    9 MiB │  0 B 
     arsc │   2.4 MiB │   2.4 MiB │  0 B │  2.4 MiB │  2.4 MiB │  0 B 
 manifest │   5.1 KiB │   5.1 KiB │  0 B │ 25.7 KiB │ 25.7 KiB │  0 B 
      res │ 910.9 KiB │ 910.9 KiB │  0 B │  1.4 MiB │  1.4 MiB │  0 B 
   native │   2.6 MiB │   2.6 MiB │  0 B │    6 MiB │    6 MiB │  0 B 
    asset │   1.6 MiB │   1.6 MiB │  0 B │  1.6 MiB │  1.6 MiB │  0 B 
    other │   1.4 MiB │   1.4 MiB │ -1 B │  1.6 MiB │  1.6 MiB │  0 B 
──────────┼───────────┼───────────┼──────┼──────────┼──────────┼──────
    total │  12.9 MiB │  12.9 MiB │ -1 B │ 22.1 MiB │ 22.1 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 42782 │ 42782 │ 0 (+0 -0) 
   types │ 15351 │ 15351 │ 0 (+0 -0) 
 classes │ 12958 │ 12958 │ 0 (+0 -0) 
 methods │ 62691 │ 62691 │ 0 (+0 -0) 
  fields │ 41698 │ 41698 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6273 │ 6273 │  0
APK
    compressed    │   uncompressed   │                                           
───────────┬──────┼───────────┬──────┤                                           
 size      │ diff │ size      │ diff │ path                                      
───────────┼──────┼───────────┼──────┼───────────────────────────────────────────
   1.2 KiB │ +4 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
     270 B │ -2 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
    54 KiB │ -2 B │   120 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  50.6 KiB │ -1 B │ 119.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
───────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 106.1 KiB │ -1 B │ 241.2 KiB │  0 B │ (total)

@amk-stripe amk-stripe marked this pull request as ready for review February 26, 2025 18:40
@amk-stripe amk-stripe requested review from a team as code owners February 26, 2025 18:40
@amk-stripe amk-stripe enabled auto-merge (squash) February 26, 2025 18:40
@amk-stripe amk-stripe requested review from cttsai-stripe and removed request for tianzhao-stripe February 26, 2025 18:40
@amk-stripe amk-stripe merged commit 4896afe into master Feb 26, 2025
16 checks passed
@amk-stripe amk-stripe deleted the update-klarna-test branch February 26, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants