Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prototype] Allow NotCurrentlyKnown price in GooglePayPaymentMethodLauncher #10265

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cttsai-stripe
Copy link
Contributor

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼──────────┬──────────┬────────
 APK      │ old       │ new       │ diff  │ old      │ new      │ diff   
──────────┼───────────┼───────────┼───────┼──────────┼──────────┼────────
      dex │   4.1 MiB │   4.1 MiB │ +30 B │    9 MiB │    9 MiB │ +104 B 
     arsc │   2.4 MiB │   2.4 MiB │   0 B │  2.4 MiB │  2.4 MiB │    0 B 
 manifest │   5.1 KiB │   5.1 KiB │   0 B │ 25.7 KiB │ 25.7 KiB │    0 B 
      res │ 910.9 KiB │ 910.9 KiB │   0 B │  1.4 MiB │  1.4 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │   0 B │    6 MiB │    6 MiB │    0 B 
    asset │   1.6 MiB │   1.6 MiB │   0 B │  1.6 MiB │  1.6 MiB │    0 B 
    other │   1.4 MiB │   1.4 MiB │  +5 B │  1.6 MiB │  1.6 MiB │    0 B 
──────────┼───────────┼───────────┼───────┼──────────┼──────────┼────────
    total │  12.9 MiB │  12.9 MiB │ +35 B │ 22.1 MiB │ 22.1 MiB │ +104 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 42783 │ 42783 │  0 (+1 -1) 
   types │ 15351 │ 15351 │  0 (+0 -0) 
 classes │ 12958 │ 12958 │  0 (+0 -0) 
 methods │ 62692 │ 62692 │  0 (+1 -1) 
  fields │ 41698 │ 41699 │ +1 (+3 -2) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6273 │ 6273 │  0
APK
    compressed    │    uncompressed    │                                           
──────────┬───────┼───────────┬────────┤                                           
 size     │ diff  │ size      │ diff   │ path                                      
──────────┼───────┼───────────┼────────┼───────────────────────────────────────────
  4.1 MiB │ +30 B │     9 MiB │ +104 B │ ∆ classes.dex                             
 50.6 KiB │  +4 B │ 119.9 KiB │    0 B │ ∆ META-INF/MANIFEST.MF                    
    272 B │  +1 B │     120 B │    0 B │ ∆ META-INF/version-control-info.textproto 
   54 KiB │  -1 B │   120 KiB │    0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │  +1 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA                       
──────────┼───────┼───────────┼────────┼───────────────────────────────────────────
  4.2 MiB │ +35 B │   9.3 MiB │ +104 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   42783 │ 42783 │ 0 (+1 -1) 
  
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"4865c4f","r8-mode":"full","version":"8.8.27"}
  
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"5720b56","r8-mode":"full","version":"8.8.27"}
  

METHODS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   62692 │ 62692 │ 0 (+1 -1) 
  
  + t6.V <init>(H, String, Long, String, String, a)
  
  - t6.V <init>(H, String, long, String, String, a)
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   41698 │ 41699 │ +1 (+3 -2) 
  
  + N4.j m: j
  + N4.j n: j[]
  + t6.V l: Long
  
  - N4.j m: j[]
  - t6.V l: long

@cttsai-stripe cttsai-stripe force-pushed the cttsai/prototype-mudflap-google-pay branch from 479749d to f1c9926 Compare February 27, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant