Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Compose Navigation to latest version #10260

Closed

Conversation

tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link

emerge-tools bot commented Feb 24, 2025

1 build increased size, 2 builds decreased size

Name Version Download Change Install Change Approval
Stripe Identity Example
com.stripe.android.identity.example.theme1
21.5.1-theme1 (20) 3.9 MB ⬆️ 1.4 kB (0.04%) 9.2 MB ⬆️ 115 B N/A
Financial Connections Example
com.stripe.android.financialconnections.example
21.5.1 (210501) 5.7 MB ⬇️ 624 B (-0.01%) 11.2 MB ⬆️ 421 B N/A
PaymentSheet Example
com.stripe.android.paymentsheet.example
21.5.1 (11) 8.6 MB ⬇️ 436 B 16.3 MB ⬆️ 102 B N/A

Stripe Identity Example 21.5.1-theme1 (20)
com.stripe.android.identity.example.theme1

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 115 B
Total download size change: ⬆️ 1.4 kB (0.04%)

Largest size changes

Item Install Size Change Download Size Change
Other ⬆️ 115 B ⬆️ 1.4 kB

Financial Connections Example 21.5.1 (210501)
com.stripe.android.financialconnections.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 421 B
Total download size change: ⬇️ 624 B (-0.01%)

Largest size changes

Item Install Size Change Download Size Change
📝 com.stripe.android.financialconnections.example.FinancialConnecti... ⬆️ 2.2 kB ⬆️ 1.0 kB
androidx.navigation.compose.NavHostKt$NavHost$32 ⬇️ -1.3 kB ⬇️ -601 B
Other ⬇️ -464 B ⬇️ -1.0 kB
View Treemap

Image of diff

PaymentSheet Example 21.5.1 (11)
com.stripe.android.paymentsheet.example

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 102 B
Total download size change: ⬇️ 436 B

Largest size changes

Item Install Size Change Download Size Change
🗑 com.stripe.android.financialconnections.features.accountpicker.Ac... ⬇️ -1.7 kB ⬇️ -758 B
Other ⬆️ 1.8 kB ⬆️ 322 B
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Copy link
Contributor

github-actions bot commented Feb 24, 2025

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed          
          ├───────────┬───────────┬──────────┼──────────┬──────────┬──────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff     
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
      dex │   4.1 MiB │   4.1 MiB │ +4.4 KiB │    9 MiB │    9 MiB │ +8.6 KiB 
     arsc │   2.4 MiB │   2.4 MiB │   -128 B │  2.4 MiB │  2.4 MiB │   -128 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │ 25.7 KiB │ 25.7 KiB │      0 B 
      res │ 910.9 KiB │ 910.9 KiB │      0 B │  1.4 MiB │  1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │    +15 B │  1.6 MiB │  1.6 MiB │    +15 B 
    other │   1.4 MiB │   1.4 MiB │    -37 B │  1.6 MiB │  1.6 MiB │      0 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
    total │  12.9 MiB │  12.9 MiB │ +4.2 KiB │ 22.1 MiB │ 22.2 MiB │ +8.5 KiB 

 DEX     │ old   │ new   │ diff               
─────────┼───────┼───────┼────────────────────
   files │     1 │     1 │    0               
 strings │ 42782 │ 42835 │  +53 (+143 -90)    
   types │ 15351 │ 15382 │  +31 (+73 -42)     
 classes │ 12958 │ 12987 │  +29 (+50 -21)     
 methods │ 62691 │ 62795 │ +104 (+5331 -5227) 
  fields │ 41698 │ 41826 │ +128 (+3320 -3192) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  243 │  243 │  0         
 entries │ 6273 │ 6271 │ -2 (+0 -2)
APK
     compressed      │     uncompressed     │                                
──────────┬──────────┼───────────┬──────────┤                                
 size     │ diff     │ size      │ diff     │ path                           
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
  4.1 MiB │ +4.4 KiB │     9 MiB │ +8.6 KiB │ ∆ classes.dex                  
  2.4 MiB │   -128 B │   2.4 MiB │   -128 B │ ∆ resources.arsc               
 50.6 KiB │    -36 B │ 119.9 KiB │      0 B │ ∆ META-INF/MANIFEST.MF         
  8.1 KiB │    +10 B │     8 KiB │    +10 B │ ∆ assets/dexopt/baseline.prof  
    1 KiB │     +5 B │     917 B │     +5 B │ ∆ assets/dexopt/baseline.profm 
  1.2 KiB │     -1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA            
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
  6.6 MiB │ +4.2 KiB │  11.6 MiB │ +8.5 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   42782 │ 42835 │ +53 (+143 -90) 
  
  +  DefaultValue: null
  +  instead of 
  + " for destination 
  + ([^/]*?|)
  + , animationSpec: 
  + , animationSpecDuration: 
  + , autoCorrectEnabled=null, keyboardType=
  + , durationNanos: 
  + , initialVelocity: 
  + , isComplete: 
  + , new instance: 
  + , platformImeOptions=nullshowKeyboardOnFocus=null, hintLocales=null)
  + , rippleAlpha=null)
  + , start: 
  + , value: 
  + . Following required arguments are missing: 
  + . Missing required arguments [
  + An instance of SeekableTransitionState has been used in different Transitions. Previous instance: 
  + Anchored drag finished
  + Cannot navigate to startDestination 
  + Cannot set route "
  + Cannot transition entry that is not in the back stack
  + Expecting fraction between 0 and 1. Got 
  + LD/N0;
  + LD/O0;
  + LD/P0;
  + LD/Q0;
  + LD/R0;
  + LD/S0;
  + LD/T0;
  + LD/U0;
  + LD/V0;
  + LD/W0;
  + LD/X0;
  + LD/Y0;
  + LD/Z0;
  + LD/a1;
  + LE/H0;
  + LFFFFFLII
  + LFFLLLI
  + LH/n;
  + LILZL
  + LJJJLII
  + LJJLII
  + LT/x3;
  + LT/y3;
  + LT/z3;
  + LT9/l0;
  + LT9/m0;
  + LT9/n0;
  + LT9/o0;
  + LT9/p0;
  + LV0/E;
  + LV2/w;
  + LZ/C;
  + LZ/D;
  + LZ/E;
  + Landroidx/compose/material/DraggableAnchorsElement;
  + Landroidx/compose/material/a;
  + Ld/i;
  + Ld/j;
  + Ld/k;
  + Ld/l;
  + Ld/m;
  + Ld2/P;
  + Ld2/Q;
  + Ld2/S;
  + Ld2/T;
  + Le2/A;
  + Le2/u;
  + Le2/v;
  + Le2/w;
  + Le2/x;
  + Le2/y;
  + Le2/z;
  + Lp1/k;
  + Lt0/Y;
  + Lt0/Z;
  + Navigation destination that matches route 
  + ReceiveChannel.consumeAsFlow can be collected just once
  + RippleConfiguration(color=
  + VFLLZLLI
  + VILLLLLLI
  + VLFLLZLL
  + VLLFL
  + VLLLLFL
  + VLLLLLLLLLIII
  + VLLLLLLLLLLIII
  + VLLLLLLLLZZZLLLLLII
  + VLLLLLLLLZZZLLLLLLII
  + VLLLLLLZFLLLI
  + VLLLLLLZFLLLLI
  + VLLLLZZLLLLLLZLZL
  + VLLLZLLLLZLLIILLI
  + VLLLZLZLLLLLLLI
  + VLLLZZLLLLLZLLLZIILLIII
  + VLLLZZLLZLLLLLLLIII
  + VLLZLLLLLLII
  + VLLZLZLLLLLLLLI
  + VLLZZLLZLLLLLLLLIII
  + VLZFLL
  + VLZLIL
  + VLZZLLLFFI
  + VZFJ
  + VZLLZLI
  + VZLZLI
  + VZZLLLFFLI
  + You cannot set a new graph on a NavController with entries on the back stack after the NavController has been destroyed. Please ensure that your NavHost has the same lifetime as your NavController.
  + You must collect the progress flow
  + You must set a start destination route
  + [LD/Z0;
  + [LE/o0;
  + [LF7/h;
  + [LJ0/S;
  + [LT/G0;
  + [LT/Z0;
  + [LT/d2;
  + [LT/t3;
  + [LT/y1;
  + [LT9/a0;
  + [LT9/b0;
  + [LT9/l0;
  + [LT9/o0;
  + [Ld2/Q;
  + [Ljava/lang/Boolean;
  + [Ljava/lang/Long;
  + [Lk0/r;
  + [Ll8/J1;
  + [Ll8/P1;
  + [Ll8/j0;
  + [Lp1/e;
  + [Lp6/j;
  + [Lr6/i;
  + deepLink
  + inputParams
  + layoutlib
  + onBack cancelled
  + progress nanos: 
  + snapTo() was canceled because state was changed to 
  + targetState while waiting for composition
  + try {
                    …tring()
                  }
  + uriPattern
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"03cd3c8","r8-mode":"full","version":"8.8.27"}
  
  - ) was not set. Did you use ModalBottomSheetState with the ModalBottomSheetLayout composable?
  - , autoCorrectEnabled=
  - , hintLocales=null)
  - , platformImeOptions=nullshowKeyboardOnFocus=
  - FFFL
  - LC8/a;
  - LF7/k;
  - LFFFFFLI
  - LJ0/f0;
  - LJJJLI
  - LV/d;
  - LV/e;
  - LZLLZLL
  - Ld0/d;
  - Ld0/e;
  - Ld0/f;
  - Lk0/B;
  - Lk0/C;
  - Lk0/D;
  - Lk0/E;
  - Lk0/F;
  - Lk0/G;
  - Lk0/H;
  - Ll8/c2;
  - Lm0/v;
  - Lo/E;
  - Lp6/t;
  - Lr6/l;
  - Lt/d;
  - Navigation destination that matches request 
  - SnapshotStateMap(value=
  - The density on ModalBottomSheetState (
  - VFLLZLLLLI
  - VILIILI
  - VILLLLLLII
  - VJIJF
  - VLFLZLLL
  - VLLFI
  - VLLLILLLI
  - VLLLLIILIJLL
  - VLLLLLLLLZZZLLLLIII
  - VLLLLLLLLZZZLLLLLIII
  - VLLLLLZFLI
  - VLLLLLZFLLI
  - VLLLLLZFLLLI
  - VLLLLLZFLLLLI
  - VLLLLZZLLLLLZLZL
  - VLLLZLLLI
  - VLLLZLLLLZLLIILLLLI
  - VLLLZLZLLLLLLI
  - VLLLZZLLLLLZLLLZIILLLLIII
  - VLLLZZLLZLLLLLLIII
  - VLLZLLLLLLLLII
  - VLLZLZLLLLLLLI
  - VLLZZLLZLLLLLLLIII
  - VLZZLLLFFII
  - VLZZLLZLLLLL
  - VLZZZZ
  - VZFLL
  - VZLLJJFLJLL
  - VZLLZLLLII
  - VZLZLLLI
  - VZZLLLFFLII
  - [LD/L0;
  - [LE/n0;
  - [LF7/j;
  - [LJ0/T;
  - [LT/A0;
  - [LT/S0;
  - [LT/a2;
  - [LT/q3;
  - [LT/u1;
  - [LT9/W;
  - [LT9/X;
  - [LT9/h0;
  - [LT9/k0;
  - [Ld2/M;
  - [Lk0/w;
  - [Ll8/M1;
  - [Ll8/Q1;
  - [Ll8/k0;
  - [Lp1/d;
  - [
...✂
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6273 │ 6271 │ -2 (+0 -2) 
  - style/FloatingDialogTheme
  - style/FloatingDialogWindowTheme

@tillh-stripe tillh-stripe changed the base branch from master to jaynewstrom/compose-1.7.4 February 24, 2025 18:59
@tillh-stripe tillh-stripe force-pushed the tillh/bump-compose-navigation branch from fb76bd5 to c50f184 Compare February 24, 2025 19:07
@tillh-stripe
Copy link
Collaborator Author

Closing, since the upgrade will be done in #9894.

@tillh-stripe tillh-stripe deleted the tillh/bump-compose-navigation branch February 24, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant