-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transparent background for Link FullScreen state #10109
Conversation
Diffuse output:
APK
|
Box { | ||
Text( | ||
modifier = Modifier | ||
.align(Alignment.TopStart), | ||
text = "Hello!" | ||
) | ||
LinkContent( | ||
navController = navController, | ||
appBarState = LinkAppBarState( | ||
navigationIcon = R.drawable.stripe_link_close, | ||
showHeader = false, | ||
showOverflowMenu = false, | ||
email = null | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that! Can we rename testContent()
to a more meaningful name like testLinkContentScreenHasOpaqueBackground()
?
a873f68
Summary
The FullScreenFlow background was affected by this commit. This PR is a fix for that.
Motivation
Testing
Screenshots
Changelog