Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transparent background for Link FullScreen state #10109

Merged
merged 3 commits into from
Feb 8, 2025

Conversation

toluo-stripe
Copy link
Contributor

@toluo-stripe toluo-stripe commented Feb 7, 2025

Summary

The FullScreenFlow background was affected by this commit. This PR is a fix for that.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
Screenshot_20250207_173643 Screenshot_20250207_173535

Changelog

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 302.6 KiB │ 302.6 KiB │  0 B │ 456.7 KiB │ 456.7 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.8 KiB │  90.8 KiB │ -5 B │   171 KiB │   171 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -5 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19975 │ 19975 │ 0 (+0 -0) 
   types │  6193 │  6193 │ 0 (+0 -0) 
 classes │  4985 │  4985 │ 0 (+0 -0) 
 methods │ 29820 │ 29820 │ 0 (+0 -0) 
  fields │ 17538 │ 17538 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3624 │ 3624 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 28.6 KiB │ -6 B │  63.2 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │ -2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
 25.4 KiB │ +2 B │  63.1 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
    272 B │ +1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 55.4 KiB │ -5 B │ 127.6 KiB │  0 B │ (total)

Comment on lines +44 to +57
Box {
Text(
modifier = Modifier
.align(Alignment.TopStart),
text = "Hello!"
)
LinkContent(
navController = navController,
appBarState = LinkAppBarState(
navigationIcon = R.drawable.stripe_link_close,
showHeader = false,
showOverflowMenu = false,
email = null
),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text will be visible in background if this surface gets removed
com stripe android link ui_LinkContentScreenshotTest_testContent DarkTheme,LargeFont

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@toluo-stripe toluo-stripe marked this pull request as ready for review February 7, 2025 23:17
@toluo-stripe toluo-stripe requested review from a team as code owners February 7, 2025 23:17
cttsai-stripe
cttsai-stripe previously approved these changes Feb 8, 2025
Copy link
Contributor

@cttsai-stripe cttsai-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! Can we rename testContent() to a more meaningful name like testLinkContentScreenHasOpaqueBackground()?

amk-stripe
amk-stripe previously approved these changes Feb 8, 2025
@toluo-stripe toluo-stripe dismissed stale reviews from amk-stripe and cttsai-stripe via a873f68 February 8, 2025 02:58
@toluo-stripe toluo-stripe merged commit 709fad8 into master Feb 8, 2025
13 checks passed
@toluo-stripe toluo-stripe deleted the tolu/link/fix_transparent_background branch February 8, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants