Add Bus Stop Name Suggestions, generalize Name Suggestions

[kmpoppe]

Resolves #5187 (Blocks #5934)

Finds Bus Stop Names around 250 m of the point the quest is asked for.
UI changed from a left-aligned simple text-input to a centered suggestion-enabled input just like road names.

Quest asked for this node, suggestions from https://www.openstreetmap.org/node/123368775 and https://www.openstreetmap.org/node/418728678

Thoughts? I'd like to get this implemented before I put #5934 to work.

[mnalis]

FYI I've built a debug APK at https://github.com/mnalis/StreetComplete/actions/runs/12737099313 (if somebody else wants to test but can't compile their own)...

You @kmpoppe could click on Actions / Build debug APK in your GitHub fork (or otherwise build / upload debug APK version so other people can help test it without having to build their own)

---

Back to the PR, I've noticed the colors are broken in dark mode (white box, too dark dropdownlist triangle) - PR version on the right:

Other than that, it seems to work as advertised: on that specific example node, it offers (and applies when selected) name=B72/Kirchweg tag

It would also be interesting how it handles if more than one language (e.g. currently it says only de) is offered (do you know of such location)?

[mnalis]

And also in Light theme, it seems that the flashing cursor / text / spacing / area for input text got bigger, and text is now centered?

[mnalis]

It would also be interesting how it handles if more than one language (e.g. currently it says only de) is offered (do you know of such location)?

https://overpass-turbo.eu/s/1X3K might be helpful in finding them. My quick test seems to indicate it works fine there too (e.g. https://www.openstreetmap.org/node/3839537126):

small_Screen_Recording_20250112_233032_StreetComplete.Dev.mp4

[kmpoppe]

And also in Light theme, it seems that the flashing cursor / text / spacing / area for input text got bigger, and text is now centered?\n\n

Yes, the quest_localizedname_row layout is a copy of ...roadname... which looks like that. I think it looks good, it might just look weird when comparing them side by side?

[kmpoppe]

Removed the forced colours, lo and behold: Dark and Light views now work as expected. See Debug APK

Light:

Dark:

[mnalis]

Removed the forced colours, lo and behold: Dark and Light views now work as expected

Hooray!

And also in Light theme, it seems that the flashing cursor / text / spacing / area for input text got bigger, and text is now centered?\n\n

Yes, the quest_localizedname_row layout is a copy of ...roadname... which looks like that. I think it looks good, it might just look weird when comparing them side by side?

It was also a loss of general decoration around text that made the empty margins look excessive. With your newest debug APK, it got that underline, so it looks better already.

I would probably look even nicer (and waste less screen real estate) if that empty space between hr and en lines was smaller, but that is just a minor cosmetic detail. (big spacing look OK on that "blue table" as it simulates how the sign might look in reality, but looks strange for regular fields - like I've enabled some fat-finger accessibility feature or something)

But not a showstopper for me (unless it is easy to fix)

[kmpoppe]

Reworked for a central NameSuggestionSource, @mnalis could you please find another example to test with more than one name?

[westnordost]

kmpoppe requested a review from westnordost

Could you first review the code yourself? Glancing over it, I am sure you will still find something.

[westnordost]

Also, generally, I'd prefer if the bus stop name and road name quests would use the name suggestions source directly rather than having a class in-between (unless there is a good reason for it - at a glance, I don't see a good reason).

[kmpoppe]

Also, generally, I'd prefer if the bus stop name and road name quests would use the name suggestions source directly rather than having a class in-between (unless there is a good reason for it - at a glance, I don't see a good reason).

I was debating that with myself and thought that specific classes would make more sense but alas, if you don't, I'll remove the specific classes and just work with NameSuggestion

[mnalis]

@mnalis could you please find another example to test with more than one name?

Sure, e.g. https://www.openstreetmap.org/node/9207779395 or https://www.openstreetmap.org/node/8208818583

(Found by some manual looking at https://overpass-turbo.eu/s/1XnZ)

[westnordost]

There were a few minor things, but since I had to dig into the code anyway and you certainly want to get on with the fixme name stuff to which this PR is merely the prerequisite, I just did those myself.

Other than small stuff like adding some explanatory comments and doc comments, the more important things I changed were:

• added fun ElementGeometry.distance(point: LatLon): Double instead of having to do this manually in the getNames function (stopped short of a more generic ElementGeometry.distance(other: ElementGeometry) function, because this complexity is not necessary for this purpose)
• no linking to some static val of AddRoadNameForm from some other class
• properly typed filter parameter in getNames

[kmpoppe]

Thanks for the edits @westnordost, the ElementGeometry.distance(points) function wouldn't have occured to me.