-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #1850: Add Overlay mtb:scale #5726
base: master
Are you sure you want to change the base?
Feature #1850: Add Overlay mtb:scale #5726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
My first thought is however that this seems to be a kind of information that is a better fit for SCEE, as I am quite skeptical if it is possible to make the pictures and descriptions short but still clear enough that they can be answered by non-experts, i.e. non-(mountain)-byciclists. But we can try, of course, for any improvement here will also benefit if it is added to SCEE instead.
A partial /quick review:
import de.westnordost.streetcomplete.view.image_select.GroupableDisplayItem | ||
import de.westnordost.streetcomplete.view.image_select.Item | ||
|
||
enum class MtbScale( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, the the title, description, image, ... should be put into extension functions in a separate file, to clearly separate the data from the resources. See e.g. SurfaceItem.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry, it was to improve readability and performance on my side, but I'll modify it for you without any worries.
import de.westnordost.streetcomplete.view.setImage | ||
import org.koin.android.ext.android.inject | ||
|
||
class MtbScaleOverlayForm : AbstractOverlayForm() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of code here and in that ViewController. Why can this not inherit from AImageSelectOverlayForm
like the WayLitForm
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better images are a hard requirement. Minimum resolution is 384x384 px
<string name="overlay_mtbScale_six">"Grade 6"</string> | ||
<string name="overlay_mtbScale_six_description">"Classify ways with 6 that are not rideable at all for a mtbiker. E.g. Chains or stemples (metal rungs) on a via ferrata or simply unsecured alpine pathes that are not even partly rideable for the very best mtbikers (using trial techniques). Steepness is often >45°. | ||
If used for single points, then this highlights exceptionally difficult spots. Often spotting is impossible and falling may be lethal."</string> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All descriptions are far too long. Also, tag values should not be mentioned. They must be understandable for non-experts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I'm not good at English, I preferred to take what was in the wiki.
For the value, no worries, did the values indicated in the old PR seem right to you?
I'm sorry, I didn't understand. You don't want this PR? There's no problem, this one can go into SCEE, it's just that as there was an open ISSUE and a former PR, we assumed that it would be of interest to you. |
I wrote, that I am skeptical if the quest/overlay guidelines can be satisfied. In the current state of the PR, they are not. But maybe the PR can be enhanced. My primary concern are the pictures in bad resolution and the very long description texts. If these texts cannot be shrunk to a fraction of the current text length without losing information important for their distinction, then it wouldn't satisfy the guidelines.
|
Regarding wording, I think indeed some guidelines could be taken from the discussion there. For example, skill is subjective, doesn't make sense to mention it at all. |
Ok, I'll let the contributors who wanted this feature help me formulate it. I'd be happy to modify the code without any worries. |
mention @torhovland @westis @RubenKelevra @CloCkWeRX @cperrier @jonpsp @rhhsm @mcliquid - who seem to have had interest in |
@mnalis sure: |
* simplify descriptions for mtb grades * drop subjective 'skill' ratings
@RubenKelevra
|
In my opinion, it doesn't make sense to have these titles at all. What is "grade 2"? Apparently, that scala is based on the "Singletrail-Skala", a standard for MTB classification used in Germany and Austria. Unclear if it has any relevance beyond that. So, also unclear if even MTB (German-speaking) enthusiasts would know that "grade 2" is equal to "Schwierigkeitsgrad 2 auf der Singletrail-Skala". We don't show the name of Unless that scale is really known beyond (some) German MTB enthusiasts. I can't judge that at the moment. |
This website has also some very concise descriptions for the different grades of the STS - in German: https://thecycleverse.com/de/blog/singletrail-skala
|
Also, very interesting information here! Turns out, there are international standard(s). I only read it vertically, but at least with the ITRS there might be a 1:1 equivalence, meaning that it might make sense to place the symbols there for better association and/or make this country-dependent which symbols are shown. |
It's not the same thing, at least in France. the mtb:scale is used on all the paths where you practice mountain biking and the mtb:scale:imba is for the stations. |
Is it like signed vs unsigned (e.g. maxheight vs maxheight:physical) or is the scale also different? E.g. mtb:scale=3 would rather bemtb:scale:imba=4 or whatever?
You would say that displaying the icons alongside the pics would rather be harmful than helpful?
My thinking is that MTBlers might generally know IMBA and how difficult each of these are.
El 11 de julio de 2024 6:46:46 CEST, Alexis Lecanu ***@***.***> escribió:
…> See also https://wiki.openstreetmap.org/wiki/Key%3Amtb%3Ascale%3Aimba
It's not the same thing, at least in France.
the mtb:scale is used on all the paths where you practice mountain biking and the mtb:scale:imba is for the stations.
You can compare this with the colours for ski slopes and the mtb:scale the difficulty for ski touring.
--
Reply to this email directly or view it on GitHub:
#5726 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
So basically it's a mix of enduro and downhill mtb difficulties. At least that's what's been done in France. imba = downhill, in resorts with facilities. |
Yes, sure. My point is this: MTB enthusiasts that want to map in streetcomplete the MTB scale of trails might know about the IMBA or ITRS scale and thus have developed a feeling which IMBA grade relates to which difficulty. Do you think this would be helpful? Or do you think this would be confusing? (And with you I mean "you people interested in MTB mapping", not only @ravenfeld alone) See also https://www.trailforks.com/map/legend/ IMBA seems to be used in US and/or internationally(?), UK/Euro is the ITRS standard. |
I'm riding MTB for fun all my life but have no idea what IMBA/ITRS classifications mean. It's like you love hiking and don't know how alpine trails are marked. 🤷♂️ |
@westnordost wrote:
Those descriptions are very good. I've merged those non-explicit surface details into our descriptions, to not overlap with the surface quest and thus not confuse the users: It's now: 0 - Firm and grippy ground. No obstacles, wide curves, moderate slope. |
A native speaker should definitely look over this. Some things sound a bit weird (TBH also in German - what's "verblockt"?) and I am not sure if these would be common terms. I could comment on this text, but maybe I end up adding more mistakes to it instead. A few comments about the content:
|
It means non-rideable objects. Meaning, you have to lift your bike over them. Agree with the rest. I think we should remove "steepness" as a detail people should map here, as we got the I gave it another shot. :) 0 - Firm and grippy ground, no obstacles, wide turns. Edit: fixed typo |
What do you mean with blocks? Boulders? Or road-blocks? Why is 1 loose ground but 2 is mostly loose ground? (Is loose ground good?) |
Road-blocks, like fallen trees or other obstacles you can't ride over. If you got a different term for this, I'm open for suggestions. I thought "blocks" would work as a translation for "verblockt".
Woops there's a "some" missing ;)
Nope, it's not "technically an obstacle" but "you need technique to overcome this obstacle". The difficulty of obstacles or paths is often referred to as "technical difficulty" and there are "technical skill required". See https://www.mtblivigno.eu/en/single-track-scale-sts Edit:
I don't think so. It leads users to see no fallen trees and say "oh no, so it must be a 4 not a 5". While 4 may very well contain fallen trees, as well as a 5 may have no trees at all along the path. The texts are also too short to explain all possible scenarios. If you look at the full descriptions of the page linked above, it's a mouth full to explain it fully. |
In the US at least, "tight turns" and "difficult turns" are often synonymous with "hairpin turns". The S1 and S2 descriptions mentions turns in the context of not having hairpin turns and narrow curves. If I am interpreting "narrow curves" correctly, another way to phrase S2 it is "narrow lines", meaning that sections of the trail, including gentler curves, require riders to follow an exact line. Also, recommendation for S3 in alignment with the S grades: That language better gets the point across IMO. |
@normaclyde right. I can see how one may confuse tight or difficult turns with hairpin turns. I modified it: 0 - Firm and grippy ground, no obstacles, wide turns. |
@normaclyde You are from the #trails or #language channel, right? Thanks for your input! |
So, the other thing that is missing are better representative images of sufficient resolution. Maybe it would make sense to open a request for contributions in the forums. |
@normaclyde wrote: Thanks, but the foreground with the trees looks a bit too busy IMHO |
I can't comment too much on whether the pictures are representative for the respective grade, so I'd leave this to people more into the MTB topic. Not sure if the MTB people know of this discussion. Maybe better on the forum? Anyway, from the point of view of StreetComplete, I'd comment:
|
As a mountain biker, I can confirm that the pictures are somewhat representative, but not quite good enough:
|
(If the current photos from the PR are deemed representative, another possibility could be to contact the original authors of the photos, asking whether they have the originals in higher resolution.) |
I appreciate the effort you put into adding the MTB scale feature. Being able to change the MTB scale of a trail directly while on the track is a fantastic addition. It’s great to see the community collaborating on this. However, I understand the challenges of trying to standardize these MTB scales globally, especially given the current state of confusion. I came across an insightful article on this topic that you may find interesting: https://www.singletracks.com/mtb-trails/why-cant-anyone-agree-on-mtb-trail-difficulty-ratings We don't have mountains or many officially designated mountain biking trails in Finland. However, we have a vast expanse of wild nature full of paths/trails in a variety of terrains, such as pine forests, swamps, high cliffs, and more. These trails are free for anyone to use, no matter if you cycle or hike. I believe that this situation is quite similar in many other countries, which is why it would be beneficial if these mtb:scale descriptions could apply to as many countries as possible. The descriptions and images should not be limited to mountainous regions and downhill-type biking. I fully agree that images should be about trails and not riders. Here's how these mtb:scale tags are used in Finland by Trailmap app, which is an extremely popular OSM-based mountain biking app. These MTB scale descriptions are here in Finnish, but I do like how these describe trails for all types of users (serious MTB riders, gravel riders, regular cyclers and even trail runners). At least, I do hope that Finnish users can use these Trailmap descriptions; otherwise, Finnish app users could mess up some existing trail difficulties. Edit. Also good to note that mtb:scale alone is not always sufficient, and trail width, surface, and other Trailmap wiki listed and here commented tags would provide much more information for trail users. Trailmap Difficulty Levels (Loosely translated): mtb:scale=0- Very Easy Path: Smooth outdoor paths and forest roads, etc. Does not require any off-road skills and can be ridden with a city bike or road bike. mtb:scale=0 Easy Path: Needle-covered path or similar smooth easy track, with few stones or roots. Does not require special off-road skills, pleasant even for beginners, and can be easily ridden with a cyclocross bike. mtb:scale=1 Intermediate Path: Small stones or roots. Obstacles can mainly be crossed with a mountain bike without bypassing. Mostly easy to ride with basic skills on a mountain bike, but a beginner may occasionally need to dismount. Still rideable with a cyclocross bike for a skilled rider. mtb:scale=2 Difficult Path: Larger stones and roots. There may be smaller drops. Requires concentration even from more experienced riders and is not easy for most, especially uphill and when wet. Cyclocross bike needs to be carried on the shoulder. mtb:scale=3 Very Difficult Path: Many large stones, roots, and other obstacles. Large drops and challenging climbs. Almost impossible to ride uphill. Requires tight concentration from experienced riders and is slow to ride. Beginners often need to push their bikes frequently. mtb:scale=4 Extremely Difficult Path: Extremely difficult due to large obstacles and height differences, requires exceptional trials-type skills to ride even very slowly. Very slow to run for trail runners as well. mtb:scale=5 Almost Impossible Path: Practically unridable for almost everyone due to large obstacles, height differences, and winding paths. Theoretically rideable with sufficient skills. mtb:scale=6 Unridable Path: Not rideable regardless of skills due to, for example, long vertical drops or large, densely located obstacles. Requires concentration even on foot. |
In my opinion the latest set of images has way too big of a difference between S0 and S1. Even if S1 is technically easily navigable and has no turns, even just the way appearing to be fairly steep and along a ridge makes it look difficult and dangerous. In contrast S0 would be fine for a traditional road bike and would be more of a 0-. I think that it would be good to have some minor roots/rocks/unevenness even in the S0 image/description. Something that's not an obstacle as such and can be easily ridden over even with narrow tires, but shows that these don't have to be totally smooth. Otherwise anything that's not passable with roller blades ends up as ≥S1. Unfortunately I couldn't find such an image just now though. I agree with TommiContursi that the images (or descriptions) shouldn't be focused on (built) downhill trails. Actually I would go so far as to say that those are the least important trails for mtb:scale, since they often already have some sort of marked difficulty, while regular forest trails etc. don't. |
Yeah that idea crossed my mind as well, as the pictures from the wiki are really hard to match up, as @torhovland pointed out. |
@TommiContursi wrote:
is your concern aimed at the images or the descriptions? Because the images were just a shot to get some responses on how to proceed and if we could replace some of the original images with higher resolution/quality ones - as it's unlikely that someone has access to all categories of tracks and can snap some pictures. But you seem to have some tracks in mind with different categories. Feel free to grab some pictures and let's discuss them! |
I am concerned about the descriptions and the images. I just went cycling in my local forest and took photos of different trails, mainly with mtb:scale ratings of 0 (or even 0-), 1, 2, and maybe 3. I have added all these photos to a Google Photos folder, and they are available for use if you're interested. https://photos.app.goo.gl/MFf5FB9AqKFiFcGa7 One challenge with the photos is that it's hard to take consistent pictures that capture all the trail features and that are easily comparable in the app. Perhaps, AI might be able to generate comparable images more easily. I have included a set of AI-generated pictures as an example. I'm not a big fan of this AI photo style, as many of these images don't look realistic and seem very AI-generated. The roots and other details are exaggerated. This is just to demonstrate what can be achieved in a short time. Getting better results would require more time and prompting. This approach would allow us to have consistent images from the exact location but with different trail difficulties. |
It could be a good idea, but the difficulty of the pins is missing, as you'll pass more easily when you're hanging straight. |
My two cents: We should stick with the OSM Wiki images and get this merged. Then somebody should update the Wiki with better and higher resolution images. And then StreetComplete should be updated with the new Wiki images. The AI images generated above is not a bad idea, even if they do look quite artificial. And they focus too much on roots. S3 and above should have other challenges than just bigger roots and rocks. |
I completely agree! It's best to start with the default images and possibly change them later. There's no need to delay this just because of that. I want to emphasize that those AI images were generated in minutes. Achieving better results would require more time and better prompting. However, I still believe that using those images would be a good way to have comparable images. Another option would be to draw images or create them using Unreal Engine. Both are time-consuming and require skills. |
I agree. I think that's the best way forward. The OSM wiki is what non SC users will use and have used for years. Those images represent what users are expecting of the trails. |
Sure, all 3 options are valid, but I agree with @torhovland that those images should be discussed on the wiki page and replaced there. I think that's better. It's also the approach SC is using for the surfaces. |
It should be noted however that:
So, regarding pictures as noted in #5726 (comment), did someone took the effort to ask at https://community.openstreetmap.org/ ? If they did, could they link the discussion here? |
@mnalis I agree entirely with your points about maintaining high-quality standards for StreetComplete, especially since the app's target users aren't familiar with OSM or MTB specifics. While images are important, having easily understandable text descriptions is even more crucial in my opinion, so I would like to reopen this can of worms. The proposed descriptions such as The earlier proposed trailmap.fi descriptions are better as they use everyday language and clearly define obstacles and skill levels required. For example, Using everyday language provides several benefits: it allows riders of all experience levels to quickly grasp what to expect from a trail by specifying the skills and bike types needed. This clarity and easy-to-understand format enable riders to make quicker, more informed decisions about whether a trail matches their skill level and equipment, improving their overall experience. However, poor descriptions can lead to inaccurate MTB scale data, as users unfamiliar with the scale may rate paths inconsistently, potentially degrading the quality of the data over time. I also agree with @TapioKn 's comment that the images (or descriptions) shouldn't focus on (built) downhill trails. These trails often already have marked difficulty levels, while regular forest trails do not. Emphasizing these regular trails is more important for the This is my two cents on the topic. While I hope the feature can be implemented quickly, I fully support your point that StreetComplete targets users who are not familiar with OSM and should not need MTB knowledge to use the Quest/Overlay. |
Nope. |
I'm sorry but how exactly is your answer different than mine? 🤔 |
@mnalis wrote:
I appreciate your feedback, but I believe it's a bit off the mark. We've dedicated several rounds to refining the texts for this quest. I suggested using images that have been the standard for rating difficulties for over a decade. In my opinion, these images are quite effective. The low resolution isn't a major issue since they are displayed small enough that it doesn't impact clarity.
While StreetComplete aims for a low entry barrier, rating MTB difficulties requires specific mountain biking knowledge. A short text and an image can’t adequately educate users on this matter. I disagree with the idea that users without MTB experience can accurately rate these difficulties. Without proper knowledge, they might input useless data, regardless of image quality. If someone has never ridden a mountain bike, they can't distinguish between easy and difficult obstacles and might rate everything as “scary.” There should be a disclaimer when enabling this layer/quest, advising only those with mountain biking experience to make changes. |
@TommiContursi wrote:
I'm sorry, but @westnordost said that "skill level" and very long descriptions are not acceptable:
@TommiContursi wrote:
Hairpin turns and steepness in percentages are used on street signs. So everyone with a driver license should readily understand those terms. So I would rate them as common knowledge and not requiring a background in cartography. I also like to mention, that you used older descriptions which have been already modified. Here's the current version:
|
I interpreted your text as: But perhaps I interpreted your text wrong. |
@HolgerJeromin What I mean is that we should update the wiki with these images before SC switches to different ones. And also make sure that this change is discussed and accepted by the community. The wiki has documented this tag for 15 years, and everyone who has tagged or used the tag likely viewed these images as reference. I also don't think their quality is bad. They were never meant to be viewed full screen. If you check the screenshot in the first post, they are actually downscaled. These images effectively convey what each grade represents, and that's what really matters. So I don't see no blocker in going forward with these images, as they are fine conveying what they are supposed to convey. |
Thank you, @RubenKelevra for sharing the updated descriptions. I appreciate the effort put into making them clearer and more user-friendly. In previous discussions, you considered dropping the term “Grade” as it may not add much value. So, I propose dropping it and instead using descriptors like “Easy” to “Unridable” to complement your existing descriptions. This approach provides intuitive cues about the trail’s nature without implying a required skill level. These initial descriptors, such as “Easy” or “Difficult,” are not meant to indicate the rider’s skill level but to provide a verbal summary of the trail’s challenges. They describe the physical characteristics of the trail itself, offering an immediate understanding of what to expect. This is particularly useful for users unfamiliar with technical MTB terminology. By focusing on the trail’s objective features, these descriptors help users make consistent assessments, supporting the accuracy and reliability of the data collected. Additionally, without clear verbal descriptions, there is a risk that users might incorrectly apply the full scale to relatively simple trails. In places like Finland, where natural trails rarely reach the higher difficulty levels of 4-6, using clear descriptors can help prevent this kind of misapplication and ensure data consistency. Here’s how your descriptions could be complemented with these initial terms:
I hope these suggestions are helpful and that the descriptions continue to be refined for usability, ensuring they remain easy and quick to interpret for all users. |
Hello, I would like to propose or not the mtb_scale or quest overlay to users. Does this seem possible on SC or should I do the code on SCEE as I had planned at the beginning? |
Uh, I haven't been following this lately, but it looks like with the help of @RubenKelevra and others, a good wording has already been found. So it looks like the only thing which is missing still since I last had a look at this PR are representative pictures in adequate resolution and quality. If you and noone else interested in this feature is able to find such pictures (but really, representative and not blurry in 384x384px is not a huge requirement, or is it?), then, well, sure you can give it a try to pose this PR to SCEE, maybe its maintainer cares less about this than I. Edit: Also, if the current texts continue to take more vertical space than a (square) picture would, it would be completely okay if the pictures had another aspect ratio, i.e. be less wide. |
Since Ruben has been playing around with AI a bit, and if really no other pictures can be found that what we currently have, maybe they could be upscaled with AI? I am often quite shocked by how good the results of such things are. After all, in terms of resolution in order to not be blurry, there isn't missing much. Edit: By the way, I do care about this PR. For example, I actually contacted the people from www.singletrail_skala.de from which these pictures are taken, whether they still have unscaled pictures. No reply though. This website seems pretty dead. (Which raises the question whether it makes sense to classify MTB trails according to this scala, but well 🤷♂️, I guess by now |
I understand. I used the images from the wiki. I thought it spoke to more people but I told myself that they are people who know the wiki. |
Further to this PR, I would like to submit this PR which adds an overlay for the mtb:scale
#5308
This also follows on from the discussion here
fixes #1850
Helium314#559
I think the icon and icons need to be reviewed for better visibility, if the community can help with this that would be great.
I wanted to make sure I had the description because it can be complicated but the dialogue doesn't help. I can't force it to 100% width.