WIP: test(KMP): use mockative instead of mockito

[riQQ]

Preparation for the move to KMP.

~150 tests are still failing. Some are blocked by bugs / missing features in Mockative, but maybe some or all of the failing tests can be changed to work around the issue or to just don't mocks.

[westnordost]

Also, I read somewhere that (at least) JavaScript does not support the fun `my quoted function name`() syntax and therefore this syntax cannot be used in multiplatform projects. I am not sure if this also applies if one does not target JS at all. But if it does, I guess all the nicely readable test functions would need to be renamed from fun `my cool function name`() to fun my_lame_function_name() (or worse, camelCase, but ...🤮)

[westnordost]

(There are conflicts with master and the PR is marked as draft, that's why I didn't look at it in detail yet. In case you need feedback about something, let me know.)

[riQQ]

Also, I read somewhere that (at least) JavaScript does not support the fun `my quoted function name`() syntax and therefore this syntax cannot be used in multiplatform projects. I am not sure if this also applies if one does not target JS at all. But if it does, I guess all the nicely readable test functions would need to be renamed from fun `my cool function name`() to fun my_lame_function_name() (or worse, camelCase, but ...🤮)

I've seen this error at some point, I think when writing a test for a Mockative bug. So you're correct that we'll have to rename the methods when switching to the KMP project structure.

[riQQ]

(There are conflicts with master and the PR is marked as draft, that's why I didn't look at it in detail yet. In case you need feedback about something, let me know.)

Yes, that's why this PR is still a draft. I don't want to put in the work if Mockative doesn't fix / implement everything that is required for the tests here. Progress has slowed down there so I'm waiting, too.

[westnordost]

Mockative and that other one not being compatible with K2, it sounds to me that Mokkery would be the only remaining option (for us), if it has the features we need.

[TSampley]

What a coincidence! I just joined the OpenStreetMap site last week as I'm looking for non-corporate alternatives to Google maps! I just saw the bad news about Mockkative 😔 - I hope I can support this nifty effort!

[westnordost]

Recently, a lot of tests are failing for me (on master), somethig something with mocks and mockito, even though I didn't even touch the mockito dependency version. So maybe with mockito this is already the same problem as with mockative, using K2 compiler. Do you (guys) also have this problem on master or is it just an issue with my setup?

[FloEdelmann]

The unit tests are passing in the GitHub Actions run on master: https://github.com/streetcomplete/StreetComplete/actions/runs/11533612917/job/32106745912

[westnordost]

hm, okay ¯\_(ツ)_/¯

[riQQ]

Mockative V3.0.0 with support for Kotlin 2 has been released recently.

There is a migration guide to V3.

[westnordost]

Cool! I hope it still makes sense for you to continue this PR despite the by now many conflicts and the fact that you need to migrate from v2 to v3.

(Say, do you know Clonk?)