Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

update protobuf version #504

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update protobuf version #504

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63ffd4b
update protobuf version
nlu90 Feb 10, 2022
5f42216
remove jaxb-api
nlu90 Feb 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ under the License.

<groupId>io.streamnative.connectors</groupId>
<artifactId>pulsar-flink-parent</artifactId>
<version>1.13.1.0</version>
<version>1.13.3.0</version>

<name>StreamNative :: Pulsar Flink Connector :: Root</name>
<packaging>pom</packaging>
Expand Down Expand Up @@ -91,8 +91,11 @@ under the License.
<slf4j.version>1.7.15</slf4j.version>

<!-- Protobuf support -->
<protobuf.version>3.11.4</protobuf.version>
<protobuf.version>3.16.1</protobuf.version>
<flink-protobuf.version>2.7.6</flink-protobuf.version>
<protobuf-plugin.version>3.11.4</protobuf-plugin.version>

<jaxb.version>2.3.0</jaxb.version>

<!-- Default scala versions, must be overwritten by build profiles, so we set something
invalid here -->
Expand Down
7 changes: 6 additions & 1 deletion pulsar-flink-connector/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ under the License.
<version>${flink.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>javax.xml.bind</groupId>
<artifactId>jaxb-api</artifactId>
<version>${jaxb.version}</version>
</dependency>
Copy link
Contributor

@syhily syhily Feb 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JAXB APIs are considered to be Java EE APIs and therefore are no longer contained on the default classpath in Java SE 9. In Java 11, they are completely removed from the JDK.

Without this dependency, maven will report class not found issue for: https://github.com/streamnative/pulsar-flink/blob/master/pulsar-flink-connector/src/main/java/org/apache/flink/streaming/connectors/pulsar/internal/DateTimeUtils.java#L23

Copy link
Contributor

@syhily syhily Feb 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DatatypeConverter could be dropped. I don't like one method dependency jar.


<!-- Test dependencies -->
<dependency>
Expand Down Expand Up @@ -234,7 +239,7 @@ under the License.
<plugin>
<groupId>com.github.os72</groupId>
<artifactId>protoc-jar-maven-plugin</artifactId>
<version>${protobuf.version}</version>
<version>${protobuf-plugin.version}</version>
<executions>
<execution>
<id>generate-protobuf-test-sources</id>
Expand Down