Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(notification): support notification retention configuration (#515)
### Motivation the PR #353 remove the default configuration of notification retention. which causes unexpected behaviour when user uses oxia as metadata service. especially for distributed lock. the revalidate after session expired will be never triggered. the current value: ``` {"level":"info","time":"2024-09-18T07:11:48.692719842Z","config":{"PublicServiceAddr":"0.0.0.0:6648","InternalServiceAddr":"0.0.0.0:6649","PeerTLS":null,"ServerTLS":null,"InternalServerTLS":null,"MetricsServiceAddr":"0.0.0.0:8080","AuthOptions":{"ProviderName":"","ProviderParams":""},"DataDir":"/data/db","WalDir":"/data/wal","WalRetentionTime":3600000000000,"WalSyncData":true,"NotificationsRetentionTime":0,"DbBlockCacheMB":4096},"time":"2024-09-18T07:11:48.693399934Z","message":"Starting Oxia server"} ``` ### Modification - Add `NotificationsRetentionTime` back and the default time is 1 hour. ### Others We might need consider filter some notification on the server when user use oxia as some storage index service(high throughput of W/R) to avoid dispatching too much messages that will impact performance.
- Loading branch information