Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide game field for Facebook #4998

Merged
merged 5 commits into from
May 14, 2024
Merged

Hide game field for Facebook #4998

merged 5 commits into from
May 14, 2024

Conversation

gettinToasty
Copy link
Contributor

this broke last night, will need to backport this bundle to v1.16.4

@gettinToasty gettinToasty added bug P0 highest priority to merge from Asana labels May 14, 2024
@gettinToasty gettinToasty marked this pull request as ready for review May 14, 2024 05:27
Copy link

bundlemon bot commented May 14, 2024

BundleMon

Files updated (1)
Status Path Size Limits
renderer.(hash).js
6.79MB (-388B -0.01%) -
Unchanged files (3)
Status Path Size Limits
vendors~renderer.(hash).js
4.69MB -
updater.js
115.28KB -
guest-api.js
40.19KB -

Total files change -388B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@michelinewu michelinewu self-requested a review May 14, 2024 12:46
@gettinToasty gettinToasty merged commit 32bef1a into master May 14, 2024
10 of 12 checks passed
@gettinToasty gettinToasty deleted the sb_hide_fb_game branch May 14, 2024 16:45
gettinToasty added a commit that referenced this pull request May 14, 2024
* Hide FB game field

* Remove game_specs from platform requests

* Remove game field from tests

* Remove show dismissable for Facebook groups. Remove console log.

* Add missing translations

---------

Co-authored-by: Micheline Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P0 highest priority to merge from Asana
Projects
None yet
2 participants