Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to resolve type if not resolved already inside from_type #3291

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patrick91
Copy link
Member

Closes #3289

Not 100% sure if this is the best way to do this, we might need
to refactor some of these parts in future 😊

Copy link

codspeed-hq bot commented Dec 13, 2023

CodSpeed Performance Report

Merging #3291 will not alter performance

Comparing feature/fix-unions-inside-generic (e5ca591) with main (5b5b717)

Summary

✅ 11 untouched benchmarks

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #3291 (e5ca591) into main (5b5b717) will decrease coverage by 0.02%.
The diff coverage is 96.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3291      +/-   ##
==========================================
- Coverage   96.59%   96.58%   -0.02%     
==========================================
  Files         482      482              
  Lines       29988    30015      +27     
  Branches     3702     3708       +6     
==========================================
+ Hits        28967    28989      +22     
- Misses        834      837       +3     
- Partials      187      189       +2     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strawberry cannot resolve type by inheriting a generic type with union type applied to it.
1 participant